From: Vivek Goyal <vgoyal@redhat.com>
To: WANG Chao <chaowang@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
Date: Wed, 15 Oct 2014 09:06:28 -0400 [thread overview]
Message-ID: <20141015130628.GA3450@redhat.com> (raw)
In-Reply-To: <20141015021431.GE2013@dhcp-17-37.nay.redhat.com>
On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote:
> On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> > On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > > Supress this unnecessary message during kernel re-build
> > > (CONFIG_KEXEC_FILE=y):
> > >
> > > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
> > >
> > > Signed-off-by: WANG Chao <chaowang@redhat.com>
> > > ---
> > > arch/x86/purgatory/Makefile | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > > index f52e033..2c835e3 100644
> > > --- a/arch/x86/purgatory/Makefile
> > > +++ b/arch/x86/purgatory/Makefile
> > > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
> > >
> > > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> > > $(call if_changed,bin2c)
> > > + @:
> >
> > Where can I find the description of "@:" and how does it work?
>
> @ is used to suppress echo'ing. See:
> https://www.gnu.org/software/make/manual/html_node/Echoing.html
>
> This is a trick to avoid "... is up to date" message". Check out commit
> a9358bc ("x86/build: Supress realmode.bin is up to date message").
Thanks for the explanations. Looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
next prev parent reply other threads:[~2014-10-15 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 4:46 [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message WANG Chao
2014-10-14 20:44 ` Peter Foley
2014-10-14 21:52 ` Vivek Goyal
2014-10-15 2:14 ` WANG Chao
2014-10-15 13:06 ` Vivek Goyal [this message]
2014-10-15 15:33 ` [tip:x86/build] x86/purgatory, build: Suppress " tip-bot for WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015130628.GA3450@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chaowang@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox