* [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
@ 2014-10-14 4:46 WANG Chao
2014-10-14 20:44 ` Peter Foley
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: WANG Chao @ 2014-10-14 4:46 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Thomas Gleixner, Ingo Molnar, maintainer:X86 ARCHITECTURE...,
Andrew Morton, Vivek Goyal, Baoquan He, Stephen Rothwell,
open list:X86 ARCHITECTURE...
Supress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):
make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
Signed-off-by: WANG Chao <chaowang@redhat.com>
---
arch/x86/purgatory/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
index f52e033..2c835e3 100644
--- a/arch/x86/purgatory/Makefile
+++ b/arch/x86/purgatory/Makefile
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
$(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
$(call if_changed,bin2c)
+ @:
obj-$(CONFIG_KEXEC_FILE) += kexec-purgatory.o
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
2014-10-14 4:46 [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message WANG Chao
@ 2014-10-14 20:44 ` Peter Foley
2014-10-14 21:52 ` Vivek Goyal
2014-10-15 15:33 ` [tip:x86/build] x86/purgatory, build: Suppress " tip-bot for WANG Chao
2 siblings, 0 replies; 6+ messages in thread
From: Peter Foley @ 2014-10-14 20:44 UTC (permalink / raw)
To: WANG Chao
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
maintainer:X86 ARCHITECTURE..., Andrew Morton, Vivek Goyal,
Baoquan He, Stephen Rothwell, open list:X86 ARCHITECTURE...
On Tue, Oct 14, 2014 at 12:46 AM, WANG Chao <chaowang@redhat.com> wrote:
> Supress this unnecessary message during kernel re-build
> (CONFIG_KEXEC_FILE=y):
>
> make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
>
> Signed-off-by: WANG Chao <chaowang@redhat.com>
Acked-by: Peter Foley <pefoley2@pefoley.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
2014-10-14 4:46 [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message WANG Chao
2014-10-14 20:44 ` Peter Foley
@ 2014-10-14 21:52 ` Vivek Goyal
2014-10-15 2:14 ` WANG Chao
2014-10-15 15:33 ` [tip:x86/build] x86/purgatory, build: Suppress " tip-bot for WANG Chao
2 siblings, 1 reply; 6+ messages in thread
From: Vivek Goyal @ 2014-10-14 21:52 UTC (permalink / raw)
To: WANG Chao
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
maintainer:X86 ARCHITECTURE..., Andrew Morton, Baoquan He,
Stephen Rothwell, open list:X86 ARCHITECTURE...
On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> Supress this unnecessary message during kernel re-build
> (CONFIG_KEXEC_FILE=y):
>
> make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
>
> Signed-off-by: WANG Chao <chaowang@redhat.com>
> ---
> arch/x86/purgatory/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> index f52e033..2c835e3 100644
> --- a/arch/x86/purgatory/Makefile
> +++ b/arch/x86/purgatory/Makefile
> @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
>
> $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> $(call if_changed,bin2c)
> + @:
Where can I find the description of "@:" and how does it work?
Thanks
Vivek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
2014-10-14 21:52 ` Vivek Goyal
@ 2014-10-15 2:14 ` WANG Chao
2014-10-15 13:06 ` Vivek Goyal
0 siblings, 1 reply; 6+ messages in thread
From: WANG Chao @ 2014-10-15 2:14 UTC (permalink / raw)
To: Vivek Goyal
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
maintainer:X86 ARCHITECTURE..., Andrew Morton, Baoquan He,
Stephen Rothwell, open list:X86 ARCHITECTURE...
On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > Supress this unnecessary message during kernel re-build
> > (CONFIG_KEXEC_FILE=y):
> >
> > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
> >
> > Signed-off-by: WANG Chao <chaowang@redhat.com>
> > ---
> > arch/x86/purgatory/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > index f52e033..2c835e3 100644
> > --- a/arch/x86/purgatory/Makefile
> > +++ b/arch/x86/purgatory/Makefile
> > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
> >
> > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> > $(call if_changed,bin2c)
> > + @:
>
> Where can I find the description of "@:" and how does it work?
@ is used to suppress echo'ing. See:
https://www.gnu.org/software/make/manual/html_node/Echoing.html
This is a trick to avoid "... is up to date" message". Check out commit
a9358bc ("x86/build: Supress realmode.bin is up to date message").
Thanks
WANG Chao
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message
2014-10-15 2:14 ` WANG Chao
@ 2014-10-15 13:06 ` Vivek Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Vivek Goyal @ 2014-10-15 13:06 UTC (permalink / raw)
To: WANG Chao
Cc: H. Peter Anvin, Thomas Gleixner, Ingo Molnar,
maintainer:X86 ARCHITECTURE..., Andrew Morton, Baoquan He,
Stephen Rothwell, open list:X86 ARCHITECTURE...
On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote:
> On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> > On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > > Supress this unnecessary message during kernel re-build
> > > (CONFIG_KEXEC_FILE=y):
> > >
> > > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
> > >
> > > Signed-off-by: WANG Chao <chaowang@redhat.com>
> > > ---
> > > arch/x86/purgatory/Makefile | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
> > > index f52e033..2c835e3 100644
> > > --- a/arch/x86/purgatory/Makefile
> > > +++ b/arch/x86/purgatory/Makefile
> > > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@
> > >
> > > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
> > > $(call if_changed,bin2c)
> > > + @:
> >
> > Where can I find the description of "@:" and how does it work?
>
> @ is used to suppress echo'ing. See:
> https://www.gnu.org/software/make/manual/html_node/Echoing.html
>
> This is a trick to avoid "... is up to date" message". Check out commit
> a9358bc ("x86/build: Supress realmode.bin is up to date message").
Thanks for the explanations. Looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:x86/build] x86/purgatory, build: Suppress kexec-purgatory.c is up to date message
2014-10-14 4:46 [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message WANG Chao
2014-10-14 20:44 ` Peter Foley
2014-10-14 21:52 ` Vivek Goyal
@ 2014-10-15 15:33 ` tip-bot for WANG Chao
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot for WANG Chao @ 2014-10-15 15:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, hpa, chaowang, tglx, linux-kernel
Commit-ID: 3ea4b8ee2419e21295cabab66c317612c5a55d26
Gitweb: http://git.kernel.org/tip/3ea4b8ee2419e21295cabab66c317612c5a55d26
Author: WANG Chao <chaowang@redhat.com>
AuthorDate: Tue, 14 Oct 2014 12:46:58 +0800
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Wed, 15 Oct 2014 08:31:21 -0700
x86/purgatory, build: Suppress kexec-purgatory.c is up to date message
Suppress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):
make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
Signed-off-by: WANG Chao <chaowang@redhat.com>
Link: http://lkml.kernel.org/r/1413262019-3759-1-git-send-email-chaowang@redhat.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/purgatory/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
index 899dd24..2c41066 100644
--- a/arch/x86/purgatory/Makefile
+++ b/arch/x86/purgatory/Makefile
@@ -23,6 +23,7 @@ quiet_cmd_bin2c = BIN2C $@
$(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
$(call if_changed,bin2c)
+ @:
obj-$(CONFIG_KEXEC_FILE) += kexec-purgatory.o
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-15 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 4:46 [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message WANG Chao
2014-10-14 20:44 ` Peter Foley
2014-10-14 21:52 ` Vivek Goyal
2014-10-15 2:14 ` WANG Chao
2014-10-15 13:06 ` Vivek Goyal
2014-10-15 15:33 ` [tip:x86/build] x86/purgatory, build: Suppress " tip-bot for WANG Chao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox