[PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Aristeu Rozanski]

It's desirable for allnconfig and tinyconfig targets to result in the
least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
switch off DEV_COREDUMP regardless if any drivers select
WANT_DEV_COREDUMP.

This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
'n' (as in allnconfig or tinyconfig) will effectively disable device
coredump.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 134f763..63a5702 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
 	  Drivers should "select" this option if they desire to use the
 	  device coredump mechanism.
 
-config DISABLE_DEV_COREDUMP
-	bool "Disable device coredump" if EXPERT
+config ENABLE_DEV_COREDUMP
+	bool "Enable device coredump" if EXPERT
+	default y
 	help
-	  Disable the device coredump mechanism despite drivers wanting to
-	  use it; this allows for more sensitive systems or systems that
-	  don't want to ever access the information to not have the code,
-	  nor keep any data.
+	  This option controls if the device coredump mechanism is available or
+	  not; if disabled, the mechanism will be omitted even if drivers that
+	  can use it are enabled.
+	  Say 'N' for more sensitive systems or systems that don't want
+	  to ever access the information to not have the code, nor keep any
+	  data.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config DEV_COREDUMP
 	bool
 	default y if WANT_DEV_COREDUMP
-	depends on !DISABLE_DEV_COREDUMP
+	depends on ENABLE_DEV_COREDUMP
 
 config DEBUG_DRIVER
 	bool "Driver Core verbose debug messages"

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Greg Kroah-Hartman]

On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote:
> It's desirable for allnconfig and tinyconfig targets to result in the
> least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> switch off DEV_COREDUMP regardless if any drivers select
> WANT_DEV_COREDUMP.
> 
> This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> 'n' (as in allnconfig or tinyconfig) will effectively disable device
> coredump.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

Any reason you didn't cc: the author of this feature / Kconfig option
about this change you are proposing?

Please resend it with the maintainer of this code in the distribution
list.

greg k-h

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Josh Triplett]

On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote:
> > It's desirable for allnconfig and tinyconfig targets to result in the
> > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > switch off DEV_COREDUMP regardless if any drivers select
> > WANT_DEV_COREDUMP.
> > 
> > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > coredump.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> 
> Any reason you didn't cc: the author of this feature / Kconfig option
> about this change you are proposing?

Likely my fault; I'd suggested using get_maintainer.pl, which does not
show that for this patch:

~/src/linux$ scripts/get_maintainer.pl < /tmp/patch
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:DRIVER CORE, KOBJ...)
linux-kernel@vger.kernel.org (open list)

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Greg Kroah-Hartman]

On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote:
> On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote:
> > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > switch off DEV_COREDUMP regardless if any drivers select
> > > WANT_DEV_COREDUMP.
> > > 
> > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > coredump.
> > > 
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> > 
> > Any reason you didn't cc: the author of this feature / Kconfig option
> > about this change you are proposing?
> 
> Likely my fault; I'd suggested using get_maintainer.pl, which does not
> show that for this patch:
> 
> ~/src/linux$ scripts/get_maintainer.pl < /tmp/patch
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:DRIVER CORE, KOBJ...)
> linux-kernel@vger.kernel.org (open list)

Yes, as that's just the Kconfig file, but at least let the person who
wrote that entry a chance to review it, that's just "being nice" :)

thanks,

greg k-h

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Josh Triplett]

On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote:
> > On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote:
> > > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > > switch off DEV_COREDUMP regardless if any drivers select
> > > > WANT_DEV_COREDUMP.
> > > > 
> > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > > coredump.
> > > > 
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > > Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> > > 
> > > Any reason you didn't cc: the author of this feature / Kconfig option
> > > about this change you are proposing?
> > 
> > Likely my fault; I'd suggested using get_maintainer.pl, which does not
> > show that for this patch:
> > 
> > ~/src/linux$ scripts/get_maintainer.pl < /tmp/patch
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:DRIVER CORE, KOBJ...)
> > linux-kernel@vger.kernel.org (open list)
> 
> Yes, as that's just the Kconfig file, but at least let the person who
> wrote that entry a chance to review it, that's just "being nice" :)

I agree; I'm just saying blame me rather than Aristeu. :)

- Josh Triplett

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Aristeu Rozanski]

On Thu, Oct 16, 2014 at 12:24:05PM +0200, Josh Triplett wrote:
> I agree; I'm just saying blame me rather than Aristeu. :)

Thanks Josh, but I should have used my brain and realized it's just the
Kconfig. Will resubmit it shortly.

-- 
Aristeu

[PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Aristeu Rozanski]

(This time Cc'ing Johannes)

It's desirable for allnconfig and tinyconfig targets to result in the
least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
switch off DEV_COREDUMP regardless if any drivers select
WANT_DEV_COREDUMP.

This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
'n' (as in allnconfig or tinyconfig) will effectively disable device
coredump.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 134f763..99d3072 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
 	  Drivers should "select" this option if they desire to use the
 	  device coredump mechanism.
 
-config DISABLE_DEV_COREDUMP
-	bool "Disable device coredump" if EXPERT
+config ENABLE_DEV_COREDUMP
+	bool "Enable device coredump" if EXPERT
+	default y
 	help
-	  Disable the device coredump mechanism despite drivers wanting to
-	  use it; this allows for more sensitive systems or systems that
-	  don't want to ever access the information to not have the code,
-	  nor keep any data.
+	  This option controls if the device coredump mechanism is available or
+	  not; if disabled, the mechanism will be omitted even if drivers that
+	  can use it are enabled.
+	  Say 'N' for more sensitive systems or systems that don't want
+	  to ever access the information to not have the code, nor keep any
+	  data.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config DEV_COREDUMP
 	bool
 	default y if WANT_DEV_COREDUMP
-	depends on !DISABLE_DEV_COREDUMP
+	depends on ENABLE_DEV_COREDUMP
 
 config DEBUG_DRIVER
 	bool "Driver Core verbose debug messages"

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Josh Triplett]

On Thu, Oct 16, 2014 at 09:36:58AM -0400, Aristeu Rozanski wrote:
> (This time Cc'ing Johannes)

This kind of note shouldn't be in the commit-message portion of the
commit.

> It's desirable for allnconfig and tinyconfig targets to result in the
> least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> switch off DEV_COREDUMP regardless if any drivers select
> WANT_DEV_COREDUMP.
> 
> This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> 'n' (as in allnconfig or tinyconfig) will effectively disable device
> coredump.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

You should have a "---" line here, followed by a diffstat.  If you're
not using git format-patch to format your patches, you should.

- Josh Triplett

> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 134f763..99d3072 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
>  	  Drivers should "select" this option if they desire to use the
>  	  device coredump mechanism.
>  
> -config DISABLE_DEV_COREDUMP
> -	bool "Disable device coredump" if EXPERT
> +config ENABLE_DEV_COREDUMP
> +	bool "Enable device coredump" if EXPERT
> +	default y
>  	help
> -	  Disable the device coredump mechanism despite drivers wanting to
> -	  use it; this allows for more sensitive systems or systems that
> -	  don't want to ever access the information to not have the code,
> -	  nor keep any data.
> +	  This option controls if the device coredump mechanism is available or
> +	  not; if disabled, the mechanism will be omitted even if drivers that
> +	  can use it are enabled.
> +	  Say 'N' for more sensitive systems or systems that don't want
> +	  to ever access the information to not have the code, nor keep any
> +	  data.
>  
> -	  If unsure, say N.
> +	  If unsure, say Y.
>  
>  config DEV_COREDUMP
>  	bool
>  	default y if WANT_DEV_COREDUMP
> -	depends on !DISABLE_DEV_COREDUMP
> +	depends on ENABLE_DEV_COREDUMP
>  
>  config DEBUG_DRIVER
>  	bool "Driver Core verbose debug messages"

[PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Aristeu Rozanski]

It's desirable for allnconfig and tinyconfig targets to result in the
least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
switch off DEV_COREDUMP regardless if any drivers select
WANT_DEV_COREDUMP.

This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
'n' (as in allnconfig or tinyconfig) will effectively disable device
coredump.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
---
 drivers/base/Kconfig | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 134f763..99d3072 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
 	  Drivers should "select" this option if they desire to use the
 	  device coredump mechanism.
 
-config DISABLE_DEV_COREDUMP
-	bool "Disable device coredump" if EXPERT
+config ENABLE_DEV_COREDUMP
+	bool "Enable device coredump" if EXPERT
+	default y
 	help
-	  Disable the device coredump mechanism despite drivers wanting to
-	  use it; this allows for more sensitive systems or systems that
-	  don't want to ever access the information to not have the code,
-	  nor keep any data.
+	  This option controls if the device coredump mechanism is available or
+	  not; if disabled, the mechanism will be omitted even if drivers that
+	  can use it are enabled.
+	  Say 'N' for more sensitive systems or systems that don't want
+	  to ever access the information to not have the code, nor keep any
+	  data.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config DEV_COREDUMP
 	bool
 	default y if WANT_DEV_COREDUMP
-	depends on !DISABLE_DEV_COREDUMP
+	depends on ENABLE_DEV_COREDUMP
 
 config DEBUG_DRIVER
 	bool "Driver Core verbose debug messages"
-- 
1.8.3.1

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Johannes Berg]

On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> It's desirable for allnconfig and tinyconfig targets to result in the
> least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> switch off DEV_COREDUMP regardless if any drivers select
> WANT_DEV_COREDUMP.
> 
> This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> 'n' (as in allnconfig or tinyconfig) will effectively disable device
> coredump.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Johannes Berg <johannes@sipsolutions.net>

Yeah, looks sensible, and should work.

johannes

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Josh Triplett]

On Mon, Oct 20, 2014 at 11:42:31AM +0200, Johannes Berg wrote:
> On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> > It's desirable for allnconfig and tinyconfig targets to result in the
> > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > switch off DEV_COREDUMP regardless if any drivers select
> > WANT_DEV_COREDUMP.
> > 
> > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > coredump.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Cc: Johannes Berg <johannes@sipsolutions.net>
> 
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> Yeah, looks sensible, and should work.

Thanks.

I've added this to the tiny/reverse-dev-coredump branch of my
tinification tree at
https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
Johannes' review, and I'll push it upstream during the 3.19 merge
window.

- Josh Triplett

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Greg Kroah-Hartman]

On Mon, Oct 20, 2014 at 04:55:11AM -0700, Josh Triplett wrote:
> On Mon, Oct 20, 2014 at 11:42:31AM +0200, Johannes Berg wrote:
> > On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > switch off DEV_COREDUMP regardless if any drivers select
> > > WANT_DEV_COREDUMP.
> > > 
> > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > coredump.
> > > 
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > Cc: Johannes Berg <johannes@sipsolutions.net>
> > 
> > Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> > 
> > Yeah, looks sensible, and should work.
> 
> Thanks.
> 
> I've added this to the tiny/reverse-dev-coredump branch of my
> tinification tree at
> https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
> Johannes' review, and I'll push it upstream during the 3.19 merge
> window.

I'll take it through the same tree this original came in and will get it
into 3.18 so we don't confuse anyone with an odd config option.

thanks,

greg k-h

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[josh]

On Tue, Oct 21, 2014 at 06:18:00AM +0800, Greg Kroah-Hartman wrote:
> On Mon, Oct 20, 2014 at 04:55:11AM -0700, Josh Triplett wrote:
> > On Mon, Oct 20, 2014 at 11:42:31AM +0200, Johannes Berg wrote:
> > > On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> > > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > > switch off DEV_COREDUMP regardless if any drivers select
> > > > WANT_DEV_COREDUMP.
> > > > 
> > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > > coredump.
> > > > 
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > > Cc: Johannes Berg <johannes@sipsolutions.net>
> > > 
> > > Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> > > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> > > 
> > > Yeah, looks sensible, and should work.
> > 
> > Thanks.
> > 
> > I've added this to the tiny/reverse-dev-coredump branch of my
> > tinification tree at
> > https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
> > Johannes' review, and I'll push it upstream during the 3.19 merge
> > window.
> 
> I'll take it through the same tree this original came in and will get it
> into 3.18 so we don't confuse anyone with an odd config option.

Excellent, dropped from tiny then.

- Josh Triplett

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

[Johannes Berg]

On Tue, 2014-10-21 at 06:18 +0800, Greg Kroah-Hartman wrote:

> > I've added this to the tiny/reverse-dev-coredump branch of my
> > tinification tree at
> > https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
> > Johannes' review, and I'll push it upstream during the 3.19 merge
> > window.
> 
> I'll take it through the same tree this original came in and will get it
> into 3.18 so we don't confuse anyone with an odd config option.

I don't know how far this commit made it, but looking at it again now I
think the new option should probably be called "Allow device coredump"
rather than "Enable device coredump" since it doesn't actually enable it
if no drivers want it.

Should I send another patch on top?

johannes