From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbaJORnV (ORCPT ); Wed, 15 Oct 2014 13:43:21 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:34994 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbaJORnT (ORCPT ); Wed, 15 Oct 2014 13:43:19 -0400 Date: Wed, 15 Oct 2014 10:43:15 -0700 From: Dmitry Torokhov To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hans de Goede , Yunkang Tang , Tommy Will , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] input: alps: Reset mouse before identifying it Message-ID: <20141015174315.GA1968@dtor-ws> References: <1412329392-5580-1-git-send-email-pali.rohar@gmail.com> <542E70CF.40205@redhat.com> <20141014060834.GA8084@dtor-glaptop> <201410151453.12115@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201410151453.12115@pali> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 02:53:11PM +0200, Pali Rohár wrote: > On Tuesday 14 October 2014 08:08:34 Dmitry Torokhov wrote: > > On Fri, Oct 03, 2014 at 11:47:59AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > Thanks for working on this! > > > > > > On 10/03/2014 11:43 AM, Pali Rohár wrote: > > > > On some systems after starting computer function > > > > alps_identify() does not detect dual ALPS > > > > touchpad+trackstick device correctly and detect only > > > > touchpad. > > > > > > > > Resetting ALPS device before identifiying it fixing this > > > > problem and both parts touchpad and trackstick are > > > > detected. > > > > > > > > Signed-off-by: Pali Rohár > > > > Tested-by: Pali Rohár > > > > > > Looks good and seems sensible: > > > > > > Acked-by: Hans de Goede > > > > *sigh* I am not really happy about this, as we making boot > > longer and longer for people without ALPS touchpads. It would > > be better if we only reset the mouse when we knew we are > > dealing with ALPS, and even better if we only reset it when > > we suspected that we missed trackstick. Any chance of doing > > this? > > > > Thanks. > > Dmitry, problem is that function check which detecting trackstick > does not working when I start my laptop from power-off state and > do not reset PS/2 device. But detecting ALPS touchpad looks like > working. So if do not like this idea, what about doing something > like this in alps_dectect function? > > int alps_detect(...) > { > ... > /* detect if device is ALPS */ > if (alps_identify(...) < 0) > return -1; > /* now we know that device is ALPS */ > if (!(flags & ALPS_DUALPOINT)) { > /* reset it and identify again, maybe there is trackstick */ > psmouse_reset(...); > alps_identify(...); > } > ... > } > > It will does not affect non ALPS devices (because first identify > call will fail), but will affect ALPS devices without trackstick > (because identify will be called twice and reset too). I think this is a step in right direction. Do you know what exactly fails in alps_identify() on your box if you do not call psmouse_reset? Thanks. -- Dmitry