linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>,
	linux-kernel@vger.kernel.org,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH resend] perf top: Add a visual cue for toggle zeroing of samples
Date: Wed, 15 Oct 2014 15:48:12 -0300	[thread overview]
Message-ID: <20141015184812.GL3198@kernel.org> (raw)
In-Reply-To: <87wq8bfksv.fsf@sejong.aot.lge.com>

Em Wed, Oct 08, 2014 at 09:48:48AM +0900, Namhyung Kim escreveu:
> Hi Taeung,
> 
> On Tue,  7 Oct 2014 16:13:15 +0900, Taeung Song wrote:
> > When 'perf top' is run, one can't easily find a difference
> > between -z option and normal output.
> > So I added a visual cue to know whether it is the zeroing or not.
> >
> > Output is as below.
> >
> > Before:
> >  $ perf top
> >
> >  Samples: 61K of event 'cycles', Event count (approx.): 3908136933
> >  Overhead  Shared Object                       Symbol
> >     1.42%  firefox                             [.] 0x0000000000011e76
> >     1.32%  libpthread-2.17.so                  [.] pthread_mutex_lock
> >
> > If you press key 'z' or run with zero option like '$ perf top --zero', it is as below.
> >
> > After:
> >  Samples: 61K of event 'cycles', Event count (approx.): 3908136933 [z]
> >  Overhead  Shared Object                       Symbol
> >     1.42%  firefox                             [.] 0x0000000000011e76
> >     1.32%  libpthread-2.17.so                  [.] pthread_mutex_lock
> >
> > Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo

  reply	other threads:[~2014-10-15 18:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07  7:13 [PATCH resend] perf top: Add a visual cue for toggle zeroing of samples Taeung Song
2014-10-08  0:48 ` Namhyung Kim
2014-10-15 18:48   ` Arnaldo Carvalho de Melo [this message]
2014-10-16  5:21 ` [tip:perf/urgent] " tip-bot for Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015184812.GL3198@kernel.org \
    --to=acme@kernel.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).