From: Felipe Balbi <balbi@ti.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Felipe Balbi <balbi@ti.com>, Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Michal Nazarewicz <mina86@mina86.com>,
Grant Likely <grant.likely@linaro.org>,
Laura Abbott <lauraa@codeaurora.org>,
Josh Cartwright <joshc@codeaurora.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] base: dma-coherent: fix device_init initialization
Date: Wed, 15 Oct 2014 15:42:51 -0500 [thread overview]
Message-ID: <20141015204251.GA5040@saruman> (raw)
In-Reply-To: <20141015133959.dd2814e196eaa3fc3bcb7b93@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
Hi,
On Wed, Oct 15, 2014 at 01:39:59PM -0700, Andrew Morton wrote:
> On Wed, 15 Oct 2014 15:32:20 -0500 Felipe Balbi <balbi@ti.com> wrote:
>
> > commit 7bfa5ab (drivers: dma-coherent: add initialization
> > from device tree) added support for dma coherent pool for
> > DeviceTree. Unfortunately that commit introduced a new
> > build warning because of a wrong type on the definition
> > of ->device_init(). This patch fixes it.
>
> Guys, when fixing a warning please always always always quote that
> warning in the changelog.
will do.
> Presumably your patch addresses the same mystery warning as did Marek's.
seems like so.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-15 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 20:32 [PATCH] base: dma-coherent: fix device_init initialization Felipe Balbi
2014-10-15 20:39 ` Andrew Morton
2014-10-15 20:42 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015204251.GA5040@saruman \
--to=balbi@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=joshc@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox