From: Andreas Werner <andreas.werner@men.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andreas Werner <andreas.werner@men.de>,
<linux-kernel@vger.kernel.org>, <wsa@the-dreams.de>,
<linux-i2c@vger.kernel.org>, <johannes.thumshirn@men.de>
Subject: Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver
Date: Thu, 16 Oct 2014 12:11:03 +0200 [thread overview]
Message-ID: <20141016101102.GA23256@awelinux> (raw)
In-Reply-To: <20141016084412.GB22265@kroah.com>
On Thu, Oct 16, 2014 at 10:44:12AM +0200, Greg KH wrote:
> On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote:
> > +struct eeprom_data {
> > + uint8_t eeprod_id;
>
> Please use the "real" kernel types, "u8" here, and "u32" in other places
> you use uint32_t (those are userspace types, not kernel types, sorry.)
>
You are right i will change it.
> > +static DEVICE_ATTR(eeprod_id, S_IRUGO, show_eeprod_id, NULL);
> > +static DEVICE_ATTR(revision, S_IRUGO, show_revision, NULL);
> > +static DEVICE_ATTR(serial, S_IRUGO, show_serialnr, NULL);
> > +static DEVICE_ATTR(hw_name, S_IRUGO, show_hw_name, NULL);
> > +static DEVICE_ATTR(prod_date, S_IRUGO, show_prod_date, NULL);
> > +static DEVICE_ATTR(rep_date, S_IRUGO, show_rep_date, NULL);
>
> DEVICE_ATTR_RO() please.
OK no problem, will change it.
Thanks.
Regards
Andy
next prev parent reply other threads:[~2014-10-16 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 8:14 [PATCH 0/2] Introduce MEN Board Information EEPROM driver Andreas Werner
2014-10-16 8:15 ` [PATCH 1/2] drivers/misc/eeprom/men_eeprod: " Andreas Werner
2014-10-16 8:44 ` Greg KH
2014-10-16 10:11 ` Andreas Werner [this message]
2014-10-16 8:58 ` Wolfram Sang
2014-10-16 9:34 ` Greg KH
2014-10-16 9:48 ` Wolfram Sang
2014-10-16 10:21 ` Andreas Werner
2014-10-16 9:59 ` Wolfram Sang
2014-10-16 11:44 ` Andreas Werner
2014-10-20 8:18 ` Wolfram Sang
2014-10-20 8:24 ` Wolfram Sang
2014-10-20 10:04 ` Andreas Werner
2014-10-20 8:33 ` Andreas Werner
2014-10-20 9:11 ` Greg KH
2014-10-20 10:09 ` Andreas Werner
2014-10-21 6:57 ` Igor Grinberg
2014-10-16 8:15 ` [PATCH 2/2] Documentation/ABI/testing/men_eeprod: Added sysfs description for men_eeprod Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016101102.GA23256@awelinux \
--to=andreas.werner@men.de \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.thumshirn@men.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox