Re: [PATCH 2/4] clk: rockchip: RK3288: add suspend and resume

Doug Anderson
2014-10-16T03:34:24Z

Chris,

On Wed, Oct 15, 2014 at 1:48 PM, <zyw@rock-chips.com> wrote:
> From: Chris Zhong <zyw@rock-chips.com>
>
> save and restore some clks, which might be changed in suspend.
>
> Signed-off-by: Tony Xie <xxx@rock-chips.com>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> ---
>
> drivers/clk/rockchip/clk-rk3288.c | 61 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)

Put this as patch set #1? It's safe to do this first and the other
patch won't work without it (right?)

> +static int rk3288_clk_suspend(void)
> +{
> + int i, reg_id;
> +
> + for (i = 0; i < ARRAY_SIZE(rk3288_saved_cru_reg_ids); i++) {
> + reg_id = rk3288_saved_cru_reg_ids[i];
> +
> + rk3288_saved_cru_regs[i] =
> + __raw_readl(rk3288_cru_base + reg_id);

As talked about off-list, should probably not be the __raw version
here and elsewhere in this file.