From: Josh Triplett <josh@joshtriplett.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Aristeu Rozanski <aris@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP
Date: Thu, 16 Oct 2014 12:24:05 +0200 [thread overview]
Message-ID: <20141016102404.GB1077@thin> (raw)
In-Reply-To: <20141016101843.GB25971@kroah.com>
On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote:
> > On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote:
> > > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > > switch off DEV_COREDUMP regardless if any drivers select
> > > > WANT_DEV_COREDUMP.
> > > >
> > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > > coredump.
> > > >
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > > Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> > >
> > > Any reason you didn't cc: the author of this feature / Kconfig option
> > > about this change you are proposing?
> >
> > Likely my fault; I'd suggested using get_maintainer.pl, which does not
> > show that for this patch:
> >
> > ~/src/linux$ scripts/get_maintainer.pl < /tmp/patch
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:DRIVER CORE, KOBJ...)
> > linux-kernel@vger.kernel.org (open list)
>
> Yes, as that's just the Kconfig file, but at least let the person who
> wrote that entry a chance to review it, that's just "being nice" :)
I agree; I'm just saying blame me rather than Aristeu. :)
- Josh Triplett
next prev parent reply other threads:[~2014-10-16 10:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 15:25 [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Aristeu Rozanski
2014-10-15 23:14 ` Greg Kroah-Hartman
2014-10-16 3:51 ` Josh Triplett
2014-10-16 10:18 ` Greg Kroah-Hartman
2014-10-16 10:24 ` Josh Triplett [this message]
2014-10-16 13:02 ` Aristeu Rozanski
-- strict thread matches above, loose matches on Subject: below --
2014-10-16 13:36 Aristeu Rozanski
2014-10-16 13:44 ` Josh Triplett
2014-10-16 15:49 ` Aristeu Rozanski
2014-10-20 9:42 ` Johannes Berg
2014-10-20 11:55 ` Josh Triplett
2014-10-20 22:18 ` Greg Kroah-Hartman
2014-10-20 23:45 ` josh
2014-10-30 8:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016102404.GB1077@thin \
--to=josh@joshtriplett.org \
--cc=aris@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox