From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Ionut Alexa <ionut.m.alexa@gmail.com>,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel:module Fix coding style errors and warnings.
Date: Thu, 16 Oct 2014 18:27:24 +0530 [thread overview]
Message-ID: <20141016125724.GA5244@sudip-PC> (raw)
In-Reply-To: <1413452333.6702.1.camel@perches.com>
On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote:
> On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
> > Fixed codin style errors and warnings. Changes printk with
> > print_debug/warn. Changed seq_printf to seq_puts.
>
> If you are going to do style cleanups, please make
> sure you check your patches with scripts/checkpatch.pl
> before sending them.
>
> WARNING: missing space after struct definition
> #104: FILE: kernel/module.c:743:
> +struct stopref{
>
> WARNING: line over 80 characters
> #190: FILE: kernel/module.c:1550:
> + error = sysfs_create_file(&mod->mkobj.kobj, &temp_attr->attr);
>
> total: 0 errors, 2 warnings, 187 lines checked
>
hi joe,
should we be doing style cleanups in the kernel files ?
previously i saw comments discouraging it as it pollutes the git blame.
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-10-16 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 9:36 [PATCH] kernel:module Fix coding style errors and warnings Ionut Alexa
2014-10-16 9:38 ` Joe Perches
2014-10-16 12:57 ` Sudip Mukherjee [this message]
2014-10-16 14:46 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2014-10-16 10:35 Ionut Alexa
2014-10-16 23:06 ` Rusty Russell
2014-10-17 8:32 Ionut Alexa
2014-10-19 23:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016125724.GA5244@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=ionut.m.alexa@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox