Re: [PATCH] kernel crypto API interface specification

[Jason Cooper <jason@lakedaemon.net>]

On Thu, Oct 16, 2014 at 06:50:58PM +0200, Stephan Mueller wrote:
> Am Donnerstag, 16. Oktober 2014, 11:06:05 schrieb Jason Cooper:
> 
> Hi Jason,
> 
> > On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote:
> > > + Grant, Geert,
> > > 
> > > Stephan has created some great example code for both the kernel crypto
> > > API and the userspace crypto API.  As examples tend to bitrot, I was
> > > wondering if the code could serve as test code.  Then it would have a
> > > triple role: API regression testing, crypto test suite, and reference
> > > implementation.
> > > 
> > > Original patch is here:
> > >   https://lkml.kernel.org/r/7502136.9BkWHTZ0th@myon.chronox.de
> > > 
> > > On Thu, Oct 16, 2014 at 09:19:08AM +0200, Stephan Mueller wrote:
> > > > Am Mittwoch, 15. Oktober 2014, 13:58:00 schrieb Jason Cooper:
> > > > > On Tue, Oct 14, 2014 at 09:46:50PM +0200, Stephan Mueller wrote:
> > ...
> > 
> > > > > Perhaps the userspace API example should be a separate file with this
> > > > > text at the top?  Seems odd having it at the end.  Also, if you copied
> > > > > it from cryptsetup, is the copyright info correct?
> > > > 
> > > > I did not copy it from cryptsetup. I only used it as a basis, especially
> > > > with the data structure handling in _kcapi_cipher_crypt. But you are
> > > > right, I changed the license for the user space by taking the
> > > > cryptsetup license.> 
> > > Ok.  It looks like Geert and Grant took part in the kernel test
> > > unconference, so I'm adding them to the Cc.  I hope they can give us
> > > some pointers as to where we could hook in this code.  Then we can
> > > simply refer to it from the userspace API document.
> > 
> > tools/testing/selftests/crypto would be a good location for the example
> > code in the next version of this patch.  Make sure to take a look at
> > tools/testing/selftests/README.txt.
> 
> Well, I have written a FIPS 140-2 CAVS test harness covering all ciphers NIST 
> is interested. Maybe this can go there?

Assuming you own the code and are willing to license it under and
compatible license, then yes.  I would keep it a separate test from
other crypto tests, though.

There may be some push back wrt it being FIPS 140-2.  But I think it's
worth considering.

thx,

Jason.