From: Michal Hocko <mhocko@suse.cz>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
David Rientjes <rientjes@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree
Date: Fri, 17 Oct 2014 08:59:47 +0200 [thread overview]
Message-ID: <20141017065947.GA8076@dhcp22.suse.cz> (raw)
In-Reply-To: <20141016203954.GA26336@redhat.com>
On Thu 16-10-14 22:39:54, Oleg Nesterov wrote:
> > Fix the issue by checking for TIF_MEMDIE thread flag and get away from the
> > fridge if it is set. oom_scan_process_thread doesn't have to check for
> > the frozen task anymore because do_send_sig_info will wake up the thread
> > and TIF_MEMDIE is already set by that time.
>
> I must have missed something... but __refrigerator() sleeps in
> TASK_UNINTERRUPTIBLE and do_send_sig_info() won't wake it up?
Ouch, I have completely missed this part when reviewing Cong's original
patch. I got confused by the retry loop. Anyway you are right and the
patch as is currently doesn't work as intented.
Can we simply make the task sleep interruptible? It retries and rechecks
the freezing conditions after wakeup anyway. It is true this would be a
user visible change because frozen tasks won't be in D state anymore
(this would make a difference for cgroup freezing because nobody would
see this in PM freezer). Does anybody depend on this?
Another possible way would be reintroducing freezer check into OOM path
and kick the task even when it is in UN state.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2014-10-17 6:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 20:39 + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Oleg Nesterov
2014-10-16 20:53 ` Cong Wang
2014-10-16 21:11 ` Oleg Nesterov
2014-10-16 21:19 ` Cong Wang
2014-10-16 21:35 ` Oleg Nesterov
2014-10-16 21:52 ` Cong Wang
2014-10-16 22:22 ` Oleg Nesterov
2014-10-17 2:33 ` Cong Wang
2014-10-17 7:46 ` [PATCH -v2] freezer: check OOM kill while being frozen Michal Hocko
2014-10-17 16:10 ` Oleg Nesterov
2014-10-17 16:20 ` Michal Hocko
2014-10-20 15:17 ` Michal Hocko
2014-10-20 17:40 ` Oleg Nesterov
2014-10-17 15:24 ` + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Oleg Nesterov
2014-10-17 16:07 ` Michal Hocko
2014-10-17 6:59 ` Michal Hocko [this message]
2014-10-17 15:31 ` Oleg Nesterov
2014-10-17 16:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017065947.GA8076@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox