Re: [patch 3/3] kernel: res_counter: remove the unused API

Michal Hocko
2014-10-16T15:05:59Z

On Thu 16-10-14 10:46:41, Johannes Weiner wrote:
> On Thu, Oct 16, 2014 at 01:20:21PM +0200, Michal Hocko wrote:
> > On Thu 16-10-14 09:20:34, Paul Bolle wrote:
> > > On Mon, 2014-10-13 at 21:46 -0400, Johannes Weiner wrote:
> > > > All memory accounting and limiting has been switched over to the
> > > > lockless page counters. Bye, res_counter!
> > > >
> > > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > > > Acked-by: Vladimir Davydov <vdavydov@parallels.com>
> > > > Acked-by: Michal Hocko <mhocko@suse.cz>
> > >
> > > This patch landed in today's linux-next (ie, next 20141016).
> > >
> > > > Documentation/cgroups/resource_counter.txt | 197 -------------------------
> > > > include/linux/res_counter.h | 223 -----------------------------
> > > > init/Kconfig | 6 -
> > > > kernel/Makefile | 1 -
> > > > kernel/res_counter.c | 211 ---------------------------
> > > > 5 files changed, 638 deletions(-)
> > > > delete mode 100644 Documentation/cgroups/resource_counter.txt
> > > > delete mode 100644 include/linux/res_counter.h
> > > > delete mode 100644 kernel/res_counter.c
> > >
> > > There's a last reference to CONFIG_RESOURCE_COUNTERS in
> > > Documentation/cgroups/memory.txt. That reference could be dropped too,
> > > couldn't it?
> > ---
> > From a54e375e85c814199f480cb4ee7a133a395c5a00 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@suse.cz>
> > Date: Thu, 16 Oct 2014 13:15:24 +0200
> > Subject: [PATCH] kernel-res_counter-remove-the-unused-api-fix
> >
> > ditch the last remainings of res_counter
> >
> > Reported-by: Paul Bolle <pebolle@tiscali.nl>
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
>
> That makes sense, although that document is still littered with
> out-of-date and seemingly irrelevant information, which is why I
> didn't bother to update it.

I would also prefer to re-write or remove it long term.

--
Michal Hocko
SUSE Labs