From: Ingo Molnar <mingo@kernel.org>
To: Daniel J Blueman <daniel@numascale.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Steffen Persvold <sp@numascale.com>
Subject: Re: [PATCH v2 2/5] Numachip: APIC fixes
Date: Sun, 19 Oct 2014 11:24:48 +0200 [thread overview]
Message-ID: <20141019092448.GA29407@gmail.com> (raw)
In-Reply-To: <1413683152-31302-2-git-send-email-daniel@numascale.com>
* Daniel J Blueman <daniel@numascale.com> wrote:
> Fix 16-bit APIC ID truncation and redundant APIC ICR idle polling for IPI
> to self (AMD64 APICs are documented in the system developer manuals to
> queue APIC writes).
That is again two fixes - there should be one fix per patch, with
a good description of what the effects of the bug were and what
the advantages of the change are - for each change separately.
Thanks,
Ingo
next prev parent reply other threads:[~2014-10-19 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 1:45 [PATCH v2 1/5] Numachip: Fix build failure with trunk GCC Daniel J Blueman
2014-10-19 1:45 ` [PATCH v2 2/5] Numachip: APIC fixes Daniel J Blueman
2014-10-19 9:24 ` Ingo Molnar [this message]
2014-10-19 1:45 ` [PATCH v2 3/5] Numachip: Add safe is-present function Daniel J Blueman
2014-10-19 1:45 ` [PATCH v2 4/5] Numachip: APIC driver cleanups Daniel J Blueman
2014-10-19 1:45 ` [PATCH v2 5/5] Numachip: use 2GB memory block size Daniel J Blueman
2014-10-19 9:23 ` Ingo Molnar
2014-10-20 7:03 ` Daniel J Blueman
2014-10-20 12:02 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019092448.GA29407@gmail.com \
--to=mingo@kernel.org \
--cc=bhelgaas@google.com \
--cc=daniel@numascale.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sp@numascale.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).