From: Johan Hovold <johan@kernel.org>
To: Nix <nix@esperi.org.uk>
Cc: Johan Hovold <johan@kernel.org>, Paul Martin <pm@debian.org>,
Oliver Neukum <oliver@neukum.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16
Date: Sun, 19 Oct 2014 15:45:51 +0200 [thread overview]
Message-ID: <20141019134551.GA2206@localhost> (raw)
In-Reply-To: <87k33yx25c.fsf@spindle.srvr.nix>
On Fri, Oct 17, 2014 at 02:21:35PM +0100, Nix wrote:
> On 14 Oct 2014, Johan Hovold outgrape:
> > Another thing you could try is to add back the
> >
> > acm_set_control(acm, 0);
> >
> > just after the dev_info message in probe.
>
> "Add back" suggests that this line existed before this change. It
> didn't, as far as I can see. Probing has
>
> acm_set_control(acm, acm->ctrlout);
>
> *shutdown* has
>
> acm_set_control(acm, acm->ctrlout = 0);
>
> Did you mean that I should try adding back the acm_set_control() during
> shutdown, or the one during probe?
After the dev_info in probe as I wrote. acm->ctrlout will always be 0 at
that point, could have been more clear about that.
Johan
next prev parent reply other threads:[~2014-10-19 13:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 23:07 [3.16.1 REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16 Nix
2014-09-01 11:09 ` Oliver Neukum
2014-09-04 23:40 ` Nix
2014-09-05 7:59 ` Oliver Neukum
2014-09-05 15:17 ` Nix
2014-09-08 7:21 ` Oliver Neukum
2014-09-08 7:58 ` Nix
2014-10-11 19:05 ` [3.16.1 BISECTED " Nix
2014-10-11 19:51 ` Paul Martin
2014-10-11 22:24 ` Nix
2014-10-12 11:14 ` Paul Martin
2014-10-12 18:58 ` Johan Hovold
2014-10-12 21:36 ` Nix
2014-10-14 8:34 ` Johan Hovold
2014-10-14 14:44 ` Nix
2014-10-17 13:21 ` Nix
2014-10-19 13:45 ` Johan Hovold [this message]
2014-10-22 9:31 ` Nix
2014-10-22 10:14 ` Johan Hovold
2014-10-22 14:00 ` Nix
2014-10-22 15:36 ` Nix
2014-10-24 11:14 ` Johan Hovold
2014-10-24 15:08 ` Nix
2014-10-31 16:44 ` Nix
2014-11-05 11:56 ` Johan Hovold
2014-11-05 15:14 ` Nix
2014-11-05 15:46 ` Daniel Silverstone
2014-11-05 18:14 ` Johan Hovold
2014-11-06 13:49 ` Nix
2014-11-06 17:04 ` Johan Hovold
2014-11-06 17:08 ` [PATCH] USB: cdc-acm: add quirk for control-line state requests Johan Hovold
2014-11-07 9:05 ` Oliver Neukum
2014-11-07 9:16 ` Johan Hovold
2014-11-07 10:23 ` Oliver Neukum
2014-11-06 17:14 ` [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16 Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019134551.GA2206@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=oliver@neukum.org \
--cc=pm@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).