From: Chen Weixiang <weixiangchen@gmail.com>
To: Konrad Zapalowicz <bergo.torino@gmail.com>
Cc: Chen Weixiang <weixiangchen@gmail.com>,
Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Greg Donald <gdonald@gmail.com>,
Chen Gang <gang.chen.5i5j@gmail.com>,
Artem Fetishev <wwctrsrx@gmail.com>,
Andrey Utkin <andrey.krieger.utkin@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: ft1000: space required after that ','
Date: Mon, 20 Oct 2014 19:38:19 +0800 [thread overview]
Message-ID: <20141020113819.GA8743@chenwx> (raw)
In-Reply-To: <20141019132700.GA3632@t400>
On Sun, Oct 19, 2014 at 03:27:00PM +0200, Konrad Zapalowicz wrote:
> On 10/19, Chen Weixiang wrote:
> > - u8 ConnectionMsg[] = {0x00,0x44,0x10,0x20,0x80,0x00,0x00,0x00,0x00,0x00,0x03,0x00,0x00,0x00,0x93,0x64,
> > - 0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x05,0x00,0x00,0x00,0x0a,
> > - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> > - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> > - 0x00,0x00,0x02,0x37,0x00,0x00,0x00,0x08,0x00,0x00,0x00,0x01,0x00,0x01,0x7f,0x00,
> > - 0x00,0x01,0x00,0x00};
> > + u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64,
> > + 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00,
> > + 0x00, 0x01, 0x00, 0x00};
>
> Nice, however it still violates the 80 characters a line rule. Please
> redo this patch.
> Thanks,
> Konrad
>
OK, I'll re-organize the array ConnectionMsg[], check the patches with
checkpatch and send the patches again. Thank you, Konrad.
--
Best regards,
Chen Weixiang (Alex)
next prev parent reply other threads:[~2014-10-20 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 12:59 [PATCH 0/7] Remove checkpatch.pl errors from drivers/staging/ft1000 Chen Weixiang
2014-10-19 12:59 ` [PATCH 1/7] staging: ft1000: do not initialise statics to 0 or NULL Chen Weixiang
2014-10-19 12:59 ` [PATCH 2/7] staging: ft1000: spaces required around that '=', '<' and '==' Chen Weixiang
2014-10-19 12:59 ` [PATCH 3/7] staging: ft1000: space required after that ',' Chen Weixiang
2014-10-19 13:27 ` Konrad Zapalowicz
2014-10-20 11:38 ` Chen Weixiang [this message]
2014-10-19 12:59 ` [PATCH 4/7] staging: ft1000: else should follow close brace '}' Chen Weixiang
2014-10-19 12:59 ` [PATCH 5/7] staging: ft1000: space prohibited after '(' and '&', before ')' Chen Weixiang
2014-10-19 12:59 ` [PATCH 6/7] staging: ft1000: "(foo*)" should be "(foo *)" Chen Weixiang
2014-10-19 12:59 ` [PATCH 7/7] staging: ft1000: "foo * bar" should be "foo *bar" Chen Weixiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020113819.GA8743@chenwx \
--to=weixiangchen@gmail.com \
--cc=andrey.krieger.utkin@gmail.com \
--cc=bergo.torino@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=wwctrsrx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox