From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbaJUGba (ORCPT ); Tue, 21 Oct 2014 02:31:30 -0400 Received: from mx2.parallels.com ([199.115.105.18]:50508 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbaJUGb3 (ORCPT ); Tue, 21 Oct 2014 02:31:29 -0400 Date: Tue, 21 Oct 2014 10:31:19 +0400 From: Vladimir Davydov To: Michal Hocko CC: Andrew Morton , Johannes Weiner , , Subject: Re: [PATCH -mm] memcg: remove activate_kmem_mutex Message-ID: <20141021063119.GM16496@esperanza> References: <1413817889-13915-1-git-send-email-vdavydov@parallels.com> <20141020185306.GB505@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20141020185306.GB505@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 20, 2014 at 08:53:06PM +0200, Michal Hocko wrote: > On Mon 20-10-14 19:11:29, Vladimir Davydov wrote: > > The activate_kmem_mutex is used to serialize memcg.kmem.limit updates, > > but we already serialize them with memcg_limit_mutex so let's remove the > > former. > > > > Signed-off-by: Vladimir Davydov > > Is this the case since bd67314586a3 (memcg, slab: simplify > synchronization scheme)? No, it's since Johannes' lockless page counters patch where we have the memcg_limit_mutex introduced to synchronize concurrent limit updates (mm commit dc1815408849 "mm: memcontrol: lockless page counters"). Thanks, Vladimir > Anyway Looks good to me. > Acked-by: Michal Hocko