* [PATCH] mtd: spi-nor: Add support for SST spi flash
@ 2014-10-21 11:37 Michal Simek
2014-10-21 11:57 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Michal Simek @ 2014-10-21 11:37 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Harini Katakam, David Woodhouse, Brian Norris, Huang Shijie,
Marek Vasut, Rafał Miłecki, Peter Crosthwaite,
Geert Uytterhoeven, linux-mtd
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
From: Harini Katakam <harini.katakam@xilinx.com>
Add sst25wf080 to the spi-nor device id table.
Signed-off-by: Harini Katakam <harinik@xilinx.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index ae16aa2f6885..0786faac2920 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -575,6 +575,7 @@ const struct spi_device_id spi_nor_ids[] = {
{ "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K | SST_WRITE) },
{ "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K | SST_WRITE) },
{ "sst25wf040", INFO(0xbf2504, 0, 64 * 1024, 8, SECT_4K | SST_WRITE) },
+ { "sst25wf080", INFO(0xbf2505, 0, 64 * 1024, 16, SECT_4K | SST_WRITE) },
/* ST Microelectronics -- newer production may have feature updates */
{ "m25p05", INFO(0x202010, 0, 32 * 1024, 2, 0) },
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
2014-10-21 11:37 [PATCH] mtd: spi-nor: Add support for SST spi flash Michal Simek
@ 2014-10-21 11:57 ` Marek Vasut
2014-10-21 16:43 ` Rafał Miłecki
2014-11-05 21:06 ` Brian Norris
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2014-10-21 11:57 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, Harini Katakam, David Woodhouse,
Brian Norris, Huang Shijie, Rafał Miłecki,
Peter Crosthwaite, Geert Uytterhoeven, linux-mtd
On Tuesday, October 21, 2014 at 01:37:59 PM, Michal Simek wrote:
> From: Harini Katakam <harini.katakam@xilinx.com>
>
> Add sst25wf080 to the spi-nor device id table.
>
> Signed-off-by: Harini Katakam <harinik@xilinx.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
2014-10-21 11:37 [PATCH] mtd: spi-nor: Add support for SST spi flash Michal Simek
2014-10-21 11:57 ` Marek Vasut
@ 2014-10-21 16:43 ` Rafał Miłecki
2014-10-21 22:08 ` Marek Vasut
2014-11-05 21:06 ` Brian Norris
2 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2014-10-21 16:43 UTC (permalink / raw)
To: Michal Simek
Cc: Linux Kernel Mailing List, monstr, Harini Katakam,
David Woodhouse, Brian Norris, Huang Shijie, Marek Vasut,
Peter Crosthwaite, Geert Uytterhoeven,
linux-mtd@lists.infradead.org
On 21 October 2014 13:37, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Harini Katakam <harini.katakam@xilinx.com>
>
> Add sst25wf080 to the spi-nor device id table.
I guess commit message could include some details. We already support
plenty of SST flashes without this patch, don't we?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
2014-10-21 16:43 ` Rafał Miłecki
@ 2014-10-21 22:08 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2014-10-21 22:08 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Michal Simek, Linux Kernel Mailing List, monstr, Harini Katakam,
David Woodhouse, Brian Norris, Huang Shijie, Peter Crosthwaite,
Geert Uytterhoeven, linux-mtd@lists.infradead.org
On Tuesday, October 21, 2014 at 06:43:50 PM, Rafał Miłecki wrote:
> On 21 October 2014 13:37, Michal Simek <michal.simek@xilinx.com> wrote:
> > From: Harini Katakam <harini.katakam@xilinx.com>
> >
> > Add sst25wf080 to the spi-nor device id table.
>
> I guess commit message could include some details. We already support
> plenty of SST flashes without this patch, don't we?
This change is so trivial that saying "we're adding this new flash chip ID to
the ID table", which is what Michal did, is completely sufficient in my opinion.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
2014-10-21 11:37 [PATCH] mtd: spi-nor: Add support for SST spi flash Michal Simek
2014-10-21 11:57 ` Marek Vasut
2014-10-21 16:43 ` Rafał Miłecki
@ 2014-11-05 21:06 ` Brian Norris
2 siblings, 0 replies; 5+ messages in thread
From: Brian Norris @ 2014-11-05 21:06 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, Marek Vasut, Peter Crosthwaite,
Geert Uytterhoeven, Rafał Miłecki, Huang Shijie,
linux-mtd, Harini Katakam, David Woodhouse
On Tue, Oct 21, 2014 at 01:37:59PM +0200, Michal Simek wrote:
> From: Harini Katakam <harini.katakam@xilinx.com>
>
> Add sst25wf080 to the spi-nor device id table.
>
> Signed-off-by: Harini Katakam <harinik@xilinx.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-05 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 11:37 [PATCH] mtd: spi-nor: Add support for SST spi flash Michal Simek
2014-10-21 11:57 ` Marek Vasut
2014-10-21 16:43 ` Rafał Miłecki
2014-10-21 22:08 ` Marek Vasut
2014-11-05 21:06 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox