From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Matej Mužila" <mmuzila@redhat.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits
Date: Tue, 21 Oct 2014 17:17:24 +0300 [thread overview]
Message-ID: <20141021141724.GM23154@mwanda> (raw)
In-Reply-To: <544658CE.8050704@redhat.com>
On Tue, Oct 21, 2014 at 02:59:58PM +0200, Matej Mužila wrote:
> > sizeof(__u8) is by definition 1 so it's perhaps surplus ?
> Now the size is now determined from the structure definition in
> include/uapi/linux/hyperv.h
>
> > - C style comments for coding style
> Fixed
>
> > Also your patch block is devoid of a few thins like the file name...
> I'm sorry, the (missing) filename mistake occured in copy-paste process.
>
Copy and paste is very error prone...
>
> Here is the patch as it (I hope) should look like:
This patch looks good, but please resend it as a proper v2 patch.
https://www.google.com/search?q=how+to+send+a+v2+patch
> ---
> From: Matej Mužila <mmuzila@redhat.com>
>
> Check if cpmsg->size is in limits of DATA_FRAGMENT
>
> Signed-off-by: Matej Mužila <mmuzila@redhat.com>
> ---
> If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
> read from memory outside of the buffer (defined at line 138).
> Added check.
Put this information in the patch description and not beyond the cut
off. That information is useful.
The cut off is meant for meta comentary to say what changed between v1
and v2 etc, which is nice to have but we don't want to preserve it.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-21 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 11:49 [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits Matej Mužila
2014-10-21 12:13 ` One Thousand Gnomes
2014-10-21 12:59 ` Matej Mužila
2014-10-21 14:17 ` Dan Carpenter [this message]
2014-10-21 14:46 ` [PATCH v2 " Matej Mužila
2014-11-07 18:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021141724.GM23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mmuzila@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox