* [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
@ 2014-10-03 16:01 Nathaniel Ting
2014-10-03 17:14 ` Greg KH
2014-10-22 8:13 ` Johan Hovold
0 siblings, 2 replies; 7+ messages in thread
From: Nathaniel Ting @ 2014-10-03 16:01 UTC (permalink / raw)
To: johan; +Cc: linux-usb, linux-kernel, Nathaniel Ting
From: Nathaniel Ting <nathaniel.ting@silabs.com>
Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
connect to host PCs over a USB serial link.
Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
---
drivers/usb/serial/cp210x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index e4bb622..ab1eb9b 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
+ { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
{ USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
{ USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
{ USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
2014-10-03 16:01 [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID Nathaniel Ting
@ 2014-10-03 17:14 ` Greg KH
2014-10-22 8:13 ` Johan Hovold
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-10-03 17:14 UTC (permalink / raw)
To: Nathaniel Ting; +Cc: johan, linux-usb, linux-kernel
On Fri, Oct 03, 2014 at 12:01:20PM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting <nathaniel.ting@silabs.com>
>
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
>
> Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..ab1eb9b 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
> { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
> { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> + { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
> { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
> { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
> { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
> --
> 1.9.1
Much better, thanks.
Johan will queue this up to his tree in a bit and will then send it on
to me.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
2014-10-03 16:01 [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID Nathaniel Ting
2014-10-03 17:14 ` Greg KH
@ 2014-10-22 8:13 ` Johan Hovold
1 sibling, 0 replies; 7+ messages in thread
From: Johan Hovold @ 2014-10-22 8:13 UTC (permalink / raw)
To: Nathaniel Ting; +Cc: johan, linux-usb, linux-kernel
On Fri, Oct 03, 2014 at 12:01:20PM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting <nathaniel.ting@silabs.com>
>
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
>
> Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
Applied, thanks.
Johan
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..ab1eb9b 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
> { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
> { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> + { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
> { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
> { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
> { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
@ 2014-10-03 15:06 Nathaniel Ting
2014-10-03 15:50 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Nathaniel Ting @ 2014-10-03 15:06 UTC (permalink / raw)
To: johan; +Cc: linux-usb, linux-kernel, Nathaniel Ting
From: Nathaniel Ting <nathaniel.ting@silabs.com>
Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
connect to host PCs over a USB serial link.
Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
---
drivers/usb/serial/cp210x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index e4bb622..ce81fa8 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
+ { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
{ USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
{ USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
{ USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
2014-10-03 15:06 Nathaniel Ting
@ 2014-10-03 15:50 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-10-03 15:50 UTC (permalink / raw)
To: Nathaniel Ting; +Cc: johan, linux-usb, linux-kernel
On Fri, Oct 03, 2014 at 11:06:33AM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting <nathaniel.ting@silabs.com>
>
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
>
> Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..ce81fa8 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
> { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
> { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> + { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
Close, but if you ran your patch through checkpatch.pl you would see
that you used spaces instead of tabs for indentation.
At least the tabs on the other lines came through correctly, which is
good.
Care to fix this up and try again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
@ 2014-10-02 21:38 Nathaniel Ting
2014-10-02 22:20 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Nathaniel Ting @ 2014-10-02 21:38 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb, linux-kernel
From: Nathaniel Ting <nathaniel.ting@silabs.com>
Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
connect to host PCs over a USB serial link.
Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
---
drivers/usb/serial/cp210x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index e4bb622..ce81fa8 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
+ { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
{ USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
{ USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
{ USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
-- 1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID.
2014-10-02 21:38 Nathaniel Ting
@ 2014-10-02 22:20 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2014-10-02 22:20 UTC (permalink / raw)
To: Nathaniel Ting; +Cc: Johan Hovold, linux-usb, linux-kernel
On Thu, Oct 02, 2014 at 05:38:17PM -0400, Nathaniel Ting wrote:
> From: Nathaniel Ting <nathaniel.ting@silabs.com>
>
> Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial
> driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now
> connect to host PCs over a USB serial link.
>
> Signed-off-by: Nathaniel Ting <nathaniel.ting@silabs.com>
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..ce81fa8 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
> { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
> { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> + { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
Your whitespace is corrupted here, making the patch impossible to apply
:(
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-22 8:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-03 16:01 [PATCH] USB: serial: cp210x: Add Silicon Labs 358x VID and PID Nathaniel Ting
2014-10-03 17:14 ` Greg KH
2014-10-22 8:13 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2014-10-03 15:06 Nathaniel Ting
2014-10-03 15:50 ` Greg KH
2014-10-02 21:38 Nathaniel Ting
2014-10-02 22:20 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox