public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Philip Munksgaard <pmunksgaard@gmail.com>,
	johan@kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: Fix indentation style issue
Date: Wed, 22 Oct 2014 11:51:12 +0200	[thread overview]
Message-ID: <20141022095112.GJ2113@localhost> (raw)
In-Reply-To: <20141011142049.GA11456@kroah.com>

On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > Fix a style issue
> > 
> > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> > ---
> >  drivers/usb/serial/option.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index d1a3f60..d88998d 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> >  	{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> >    	  .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > -  	},
> > +	},
> 
> Why not fix the same 'space' issue on the line before this at the same
> time?

And what about the remaining white-space issues in this file? Do we
really want to go down this path?

I could take a patch fixing them all at once (this time). It's you
who'll have to deal with the changed contexts when back porting device
ids, Greg. ;)

Johan

  parent reply	other threads:[~2014-10-22  9:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 13:49 [PATCH] usb: serial: Fix indentation style issue Philip Munksgaard
2014-10-11 14:20 ` Greg KH
2014-10-11 14:51   ` Lars Melin
2014-10-11 15:36   ` Joe Perches
2014-10-11 20:19     ` Greg KH
2014-10-12  1:02       ` Joe Perches
2014-10-22  9:51   ` Johan Hovold [this message]
2014-10-22 14:18     ` Greg KH
2014-10-22 14:40       ` Philip Munksgaard
2014-10-22 14:40         ` Johan Hovold
2014-10-22 21:14       ` Paul Zimmerman
2014-10-22 21:40         ` Greg KH
2014-10-11 15:24 ` [PATCH v2] " Philip Munksgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022095112.GJ2113@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmunksgaard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox