From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: max77693: Fix a truncate warning
Date: Wed, 22 Oct 2014 12:38:11 +0100 [thread overview]
Message-ID: <20141022113811.GL4939@x1> (raw)
In-Reply-To: <1413289537-10951-1-git-send-email-k.kozlowski@samsung.com>
On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:
> Fix warning on x86_64, make allyesconfig:
>
> drivers/mfd/max77693.c: In function ‘max77693_i2c_probe’:
> drivers/mfd/max77693.c:259:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> SRC_IRQ_ALL, ~SRC_IRQ_ALL);
> ^
Applied and fixed up into:
mfd: max77693: Fix always masked MUIC interrupts
Thanks.
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 4e4e6a1a6301..0c9ec6bae022 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -256,7 +256,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
> /* Unmask interrupts from all blocks in interrupt source register */
> ret = regmap_update_bits(max77693->regmap,
> MAX77693_PMIC_REG_INTSRC_MASK,
> - SRC_IRQ_ALL, ~SRC_IRQ_ALL);
> + SRC_IRQ_ALL, (unsigned int)~SRC_IRQ_ALL);
> if (ret < 0) {
> dev_err(max77693->dev,
> "Could not unmask interrupts in INTSRC: %d\n",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-10-22 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 12:25 [PATCH] mfd: max77693: Fix a truncate warning Krzysztof Kozlowski
2014-10-22 11:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022113811.GL4939@x1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox