* [PATCH] mfd: max77693: Fix a truncate warning
@ 2014-10-14 12:25 Krzysztof Kozlowski
2014-10-22 11:38 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2014-10-14 12:25 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, linux-kernel; +Cc: Krzysztof Kozlowski
Fix warning on x86_64, make allyesconfig:
drivers/mfd/max77693.c: In function ‘max77693_i2c_probe’:
drivers/mfd/max77693.c:259:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
SRC_IRQ_ALL, ~SRC_IRQ_ALL);
^
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/mfd/max77693.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 4e4e6a1a6301..0c9ec6bae022 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -256,7 +256,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
/* Unmask interrupts from all blocks in interrupt source register */
ret = regmap_update_bits(max77693->regmap,
MAX77693_PMIC_REG_INTSRC_MASK,
- SRC_IRQ_ALL, ~SRC_IRQ_ALL);
+ SRC_IRQ_ALL, (unsigned int)~SRC_IRQ_ALL);
if (ret < 0) {
dev_err(max77693->dev,
"Could not unmask interrupts in INTSRC: %d\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: max77693: Fix a truncate warning
2014-10-14 12:25 [PATCH] mfd: max77693: Fix a truncate warning Krzysztof Kozlowski
@ 2014-10-22 11:38 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-10-22 11:38 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Samuel Ortiz, linux-kernel
On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:
> Fix warning on x86_64, make allyesconfig:
>
> drivers/mfd/max77693.c: In function ‘max77693_i2c_probe’:
> drivers/mfd/max77693.c:259:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> SRC_IRQ_ALL, ~SRC_IRQ_ALL);
> ^
Applied and fixed up into:
mfd: max77693: Fix always masked MUIC interrupts
Thanks.
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 4e4e6a1a6301..0c9ec6bae022 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -256,7 +256,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
> /* Unmask interrupts from all blocks in interrupt source register */
> ret = regmap_update_bits(max77693->regmap,
> MAX77693_PMIC_REG_INTSRC_MASK,
> - SRC_IRQ_ALL, ~SRC_IRQ_ALL);
> + SRC_IRQ_ALL, (unsigned int)~SRC_IRQ_ALL);
> if (ret < 0) {
> dev_err(max77693->dev,
> "Could not unmask interrupts in INTSRC: %d\n",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-22 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 12:25 [PATCH] mfd: max77693: Fix a truncate warning Krzysztof Kozlowski
2014-10-22 11:38 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox