* [PATCH] usb: serial: Fix indentation style issue
@ 2014-10-11 13:49 Philip Munksgaard
2014-10-11 14:20 ` Greg KH
2014-10-11 15:24 ` [PATCH v2] " Philip Munksgaard
0 siblings, 2 replies; 13+ messages in thread
From: Philip Munksgaard @ 2014-10-11 13:49 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, Philip Munksgaard
Fix a style issue
Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
--
2.1.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 13:49 [PATCH] usb: serial: Fix indentation style issue Philip Munksgaard
@ 2014-10-11 14:20 ` Greg KH
2014-10-11 14:51 ` Lars Melin
` (2 more replies)
2014-10-11 15:24 ` [PATCH v2] " Philip Munksgaard
1 sibling, 3 replies; 13+ messages in thread
From: Greg KH @ 2014-10-11 14:20 UTC (permalink / raw)
To: Philip Munksgaard; +Cc: johan, linux-usb, linux-kernel
On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> Fix a style issue
>
> Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> ---
> drivers/usb/serial/option.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index d1a3f60..d88998d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> - },
> + },
Why not fix the same 'space' issue on the line before this at the same
time?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 14:20 ` Greg KH
@ 2014-10-11 14:51 ` Lars Melin
2014-10-11 15:36 ` Joe Perches
2014-10-22 9:51 ` Johan Hovold
2 siblings, 0 replies; 13+ messages in thread
From: Lars Melin @ 2014-10-11 14:51 UTC (permalink / raw)
To: Greg KH, Philip Munksgaard; +Cc: johan, linux-usb, linux-kernel
On 2014-10-11 21:20, Greg KH wrote:
> On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
>> Fix a style issue
>>
>> Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
>> ---
>> drivers/usb/serial/option.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index d1a3f60..d88998d 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
>> { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
>> { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
>> .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
>> - },
>> + },
> Why not fix the same 'space' issue on the line before this at the same
> time?
>
Why put the closing brace on a new line?
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] usb: serial: Fix indentation style issue
2014-10-11 13:49 [PATCH] usb: serial: Fix indentation style issue Philip Munksgaard
2014-10-11 14:20 ` Greg KH
@ 2014-10-11 15:24 ` Philip Munksgaard
1 sibling, 0 replies; 13+ messages in thread
From: Philip Munksgaard @ 2014-10-11 15:24 UTC (permalink / raw)
To: johan; +Cc: gregkh, linux-usb, linux-kernel, Philip Munksgaard
Fix a style issue.
Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
---
drivers/usb/serial/option.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..64ddc00 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1615,8 +1615,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(AIRPLUS_VENDOR_ID, AIRPLUS_PRODUCT_MCD650) },
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
- .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ .driver_info = (kernel_ulong_t)&four_g_w14_blacklist },
{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
--
2.1.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 14:20 ` Greg KH
2014-10-11 14:51 ` Lars Melin
@ 2014-10-11 15:36 ` Joe Perches
2014-10-11 20:19 ` Greg KH
2014-10-22 9:51 ` Johan Hovold
2 siblings, 1 reply; 13+ messages in thread
From: Joe Perches @ 2014-10-11 15:36 UTC (permalink / raw)
To: Greg KH; +Cc: Philip Munksgaard, johan, linux-usb, linux-kernel
On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote:
> On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > Fix a style issue
[]
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
[]
> > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > - },
> > + },
>
> Why not fix the same 'space' issue on the line before this at the same
> time?
I think there is no space issue on the previous line.
What do you see Greg?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 15:36 ` Joe Perches
@ 2014-10-11 20:19 ` Greg KH
2014-10-12 1:02 ` Joe Perches
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2014-10-11 20:19 UTC (permalink / raw)
To: Joe Perches; +Cc: Philip Munksgaard, johan, linux-usb, linux-kernel
On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote:
> On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote:
> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > Fix a style issue
> []
> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> []
> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > - },
> > > + },
> >
> > Why not fix the same 'space' issue on the line before this at the same
> > time?
>
> I think there is no space issue on the previous line.
> What do you see Greg?
I see 'space space tab', just like this line that is being changed.
/me hands Joe a real editor.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 20:19 ` Greg KH
@ 2014-10-12 1:02 ` Joe Perches
0 siblings, 0 replies; 13+ messages in thread
From: Joe Perches @ 2014-10-12 1:02 UTC (permalink / raw)
To: Greg KH; +Cc: Philip Munksgaard, johan, linux-usb, linux-kernel
On Sat, 2014-10-11 at 13:19 -0700, Greg KH wrote:
> On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote:
> > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote:
> > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > > Fix a style issue
> > []
> > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > []
> > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > > - },
> > > > + },
> > >
> > > Why not fix the same 'space' issue on the line before this at the same
> > > time?
> >
> > I think there is no space issue on the previous line.
> > What do you see Greg?
>
> I see 'space space tab', just like this line that is being changed.
Right, silly evolution previewer can't differentiate space/tab
> /me hands Joe a real editor.
Well, where is it? ;)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-11 14:20 ` Greg KH
2014-10-11 14:51 ` Lars Melin
2014-10-11 15:36 ` Joe Perches
@ 2014-10-22 9:51 ` Johan Hovold
2014-10-22 14:18 ` Greg KH
2 siblings, 1 reply; 13+ messages in thread
From: Johan Hovold @ 2014-10-22 9:51 UTC (permalink / raw)
To: Greg KH; +Cc: Philip Munksgaard, johan, linux-usb, linux-kernel
On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > Fix a style issue
> >
> > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> > ---
> > drivers/usb/serial/option.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index d1a3f60..d88998d 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > - },
> > + },
>
> Why not fix the same 'space' issue on the line before this at the same
> time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
I could take a patch fixing them all at once (this time). It's you
who'll have to deal with the changed contexts when back porting device
ids, Greg. ;)
Johan
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-22 9:51 ` Johan Hovold
@ 2014-10-22 14:18 ` Greg KH
2014-10-22 14:40 ` Philip Munksgaard
2014-10-22 21:14 ` Paul Zimmerman
0 siblings, 2 replies; 13+ messages in thread
From: Greg KH @ 2014-10-22 14:18 UTC (permalink / raw)
To: Johan Hovold; +Cc: Philip Munksgaard, linux-usb, linux-kernel
On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > Fix a style issue
> > >
> > > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> > > ---
> > > drivers/usb/serial/option.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > > index d1a3f60..d88998d 100644
> > > --- a/drivers/usb/serial/option.c
> > > +++ b/drivers/usb/serial/option.c
> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > - },
> > > + },
> >
> > Why not fix the same 'space' issue on the line before this at the same
> > time?
>
> And what about the remaining white-space issues in this file? Do we
> really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.
Just don't add new whitespace issues please, that's all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-22 14:18 ` Greg KH
@ 2014-10-22 14:40 ` Philip Munksgaard
2014-10-22 14:40 ` Johan Hovold
2014-10-22 21:14 ` Paul Zimmerman
1 sibling, 1 reply; 13+ messages in thread
From: Philip Munksgaard @ 2014-10-22 14:40 UTC (permalink / raw)
To: Greg KH; +Cc: Johan Hovold, linux-usb, linux-kernel
On 22 October 2014 16:18, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
>> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
>> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
>> > > Fix a style issue
>> > >
>> > > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
>> > > ---
>> > > drivers/usb/serial/option.c | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> > > index d1a3f60..d88998d 100644
>> > > --- a/drivers/usb/serial/option.c
>> > > +++ b/drivers/usb/serial/option.c
>> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
>> > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
>> > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
>> > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
>> > > - },
>> > > + },
>> >
>> > Why not fix the same 'space' issue on the line before this at the same
>> > time?
>>
>> And what about the remaining white-space issues in this file? Do we
>> really want to go down this path?
>
> No, we don't, if you want to have patches be able to apply properly to
> older kernels, as you point out.
>
> Just don't add new whitespace issues please, that's all.
>
I'm a bit confused. I've already submitted a new patch that merges the
two lines and fixes the whitespace issues on both (if you can't find
it, let me know and I'll resend it), is there anything else I'm
supposed to do?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-22 14:40 ` Philip Munksgaard
@ 2014-10-22 14:40 ` Johan Hovold
0 siblings, 0 replies; 13+ messages in thread
From: Johan Hovold @ 2014-10-22 14:40 UTC (permalink / raw)
To: Philip Munksgaard; +Cc: Greg KH, Johan Hovold, linux-usb, linux-kernel
On Wed, Oct 22, 2014 at 04:40:24PM +0200, Philip Munksgaard wrote:
> On 22 October 2014 16:18, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> >> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> >> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> >> > > Fix a style issue
> >> > >
> >> > > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> >> > > ---
> >> > > drivers/usb/serial/option.c | 2 +-
> >> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> > >
> >> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> >> > > index d1a3f60..d88998d 100644
> >> > > --- a/drivers/usb/serial/option.c
> >> > > +++ b/drivers/usb/serial/option.c
> >> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> >> > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> >> > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> >> > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> >> > > - },
> >> > > + },
> >> >
> >> > Why not fix the same 'space' issue on the line before this at the same
> >> > time?
> >>
> >> And what about the remaining white-space issues in this file? Do we
> >> really want to go down this path?
> >
> > No, we don't, if you want to have patches be able to apply properly to
> > older kernels, as you point out.
> >
> > Just don't add new whitespace issues please, that's all.
>
> I'm a bit confused. I've already submitted a new patch that merges the
> two lines and fixes the whitespace issues on both (if you can't find
> it, let me know and I'll resend it), is there anything else I'm
> supposed to do?
No, we're just not going to apply such fix-white-space patches, sorry.
Johan
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] usb: serial: Fix indentation style issue
2014-10-22 14:18 ` Greg KH
2014-10-22 14:40 ` Philip Munksgaard
@ 2014-10-22 21:14 ` Paul Zimmerman
2014-10-22 21:40 ` Greg KH
1 sibling, 1 reply; 13+ messages in thread
From: Paul Zimmerman @ 2014-10-22 21:14 UTC (permalink / raw)
To: Greg KH, Johan Hovold
Cc: Philip Munksgaard, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-owner@vger.kernel.org] On Behalf Of Greg KH
> Sent: Wednesday, October 22, 2014 7:19 AM
>
> On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > > Fix a style issue
> > > >
> > > > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> > > > ---
> > > > drivers/usb/serial/option.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > > > index d1a3f60..d88998d 100644
> > > > --- a/drivers/usb/serial/option.c
> > > > +++ b/drivers/usb/serial/option.c
> > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > > - },
> > > > + },
> > >
> > > Why not fix the same 'space' issue on the line before this at the same
> > > time?
> >
> > And what about the remaining white-space issues in this file? Do we
> > really want to go down this path?
>
> No, we don't, if you want to have patches be able to apply properly to
> older kernels, as you point out.
git-apply --ignore-whitespace ?
--
Paul
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] usb: serial: Fix indentation style issue
2014-10-22 21:14 ` Paul Zimmerman
@ 2014-10-22 21:40 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2014-10-22 21:40 UTC (permalink / raw)
To: Paul Zimmerman
Cc: Johan Hovold, Philip Munksgaard, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
On Wed, Oct 22, 2014 at 09:14:14PM +0000, Paul Zimmerman wrote:
> > From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-owner@vger.kernel.org] On Behalf Of Greg KH
> > Sent: Wednesday, October 22, 2014 7:19 AM
> >
> > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> > > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> > > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > > > Fix a style issue
> > > > >
> > > > > Signed-off-by: Philip Munksgaard <pmunksgaard@gmail.com>
> > > > > ---
> > > > > drivers/usb/serial/option.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > > > > index d1a3f60..d88998d 100644
> > > > > --- a/drivers/usb/serial/option.c
> > > > > +++ b/drivers/usb/serial/option.c
> > > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > > > - },
> > > > > + },
> > > >
> > > > Why not fix the same 'space' issue on the line before this at the same
> > > > time?
> > >
> > > And what about the remaining white-space issues in this file? Do we
> > > really want to go down this path?
> >
> > No, we don't, if you want to have patches be able to apply properly to
> > older kernels, as you point out.
>
> git-apply --ignore-whitespace ?
Doesn't work with my code-flow for handling stable patches, sorry.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-10-22 21:41 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-11 13:49 [PATCH] usb: serial: Fix indentation style issue Philip Munksgaard
2014-10-11 14:20 ` Greg KH
2014-10-11 14:51 ` Lars Melin
2014-10-11 15:36 ` Joe Perches
2014-10-11 20:19 ` Greg KH
2014-10-12 1:02 ` Joe Perches
2014-10-22 9:51 ` Johan Hovold
2014-10-22 14:18 ` Greg KH
2014-10-22 14:40 ` Philip Munksgaard
2014-10-22 14:40 ` Johan Hovold
2014-10-22 21:14 ` Paul Zimmerman
2014-10-22 21:40 ` Greg KH
2014-10-11 15:24 ` [PATCH v2] " Philip Munksgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox