From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Olof Johansson <olof@lixom.net>, Chris Zhong <zyw@rock-chips.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties
Date: Wed, 22 Oct 2014 17:48:13 +0100 [thread overview]
Message-ID: <20141022164813.GD2344@sirena.org.uk> (raw)
In-Reply-To: <1413816472-1895-5-git-send-email-javier.martinez@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Mon, Oct 20, 2014 at 04:47:51PM +0200, Javier Martinez Canillas wrote:
> + char *states[PM_SUSPEND_MAX + 1] = {
> + [PM_SUSPEND_MEM] = "regulator-state-mem",
> + [PM_SUSPEND_MAX] = "regulator-state-disk",
> + };
This still has the same problem as your previous patch with things not
being as joined up with the core as they should be. What I'd like to
see is that the code to extract the number for each state is in the core
and then the drivers just provide a translation function to map from
this to the internal modes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-22 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 14:47 [PATCH v3 0/5] Add max77802 regulator operating mode support Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 1/5] regulator: of: Decrement refcount for suspend state nodes Javier Martinez Canillas
2014-10-22 16:38 ` Mark Brown
2014-10-20 14:47 ` [PATCH v3 2/5] regulator: core: Add regulator mode and initial mode properties Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 3/5] regulator: max77802: Document regulator operating modes Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties Javier Martinez Canillas
2014-10-22 16:48 ` Mark Brown [this message]
2014-10-23 9:28 ` Javier Martinez Canillas
2014-10-24 21:02 ` Mark Brown
2014-10-26 23:24 ` Javier Martinez Canillas
2014-10-20 14:47 ` [PATCH v3 5/5] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022164813.GD2344@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox