From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933541AbaJVNDG (ORCPT ); Wed, 22 Oct 2014 09:03:06 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:23754 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933439AbaJVNDF (ORCPT ); Wed, 22 Oct 2014 09:03:05 -0400 Date: Wed, 22 Oct 2014 21:00:12 +0800 From: Jisheng Zhang To: "tglx@linutronix.de" , "jason@lakedaemon.net" CC: "sebastian.hesselbarth@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] irqchip: dw-apb-ictl: select GENERIC_IRQ_CHIP Message-ID: <20141022210012.6b650067@xhacker> In-Reply-To: <1413982524-470-1-git-send-email-jszhang@marvell.com> References: <1413982524-470-1-git-send-email-jszhang@marvell.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-10-22_04:2014-10-22,2014-10-22,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1410220118 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org oops, typo. Should be generic chip functions. Please ignore this patch, I will send the v2. sorry On Wed, 22 Oct 2014 05:55:24 -0700 Jisheng Zhang wrote: > The dw-apb-ictl driver uses the clocksource MMIO functions. > Thus it needs to select GENERIC_IRQ_CHIP in Kconfig. > > Signed-off-by: Jisheng Zhang > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index b21f12f..a925da0 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -56,6 +56,7 @@ config BRCMSTB_L2_IRQ > > config DW_APB_ICTL > bool > + select GENERIC_IRQ_CHIP > select IRQ_DOMAIN > > config IMGPDC_IRQ