From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Robert Richter <rric@kernel.org>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
kan.liang@intel.com, adrian.hunter@intel.com, acme@infradead.org
Subject: Re: [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams
Date: Thu, 23 Oct 2014 05:05:41 +0200 [thread overview]
Message-ID: <20141023030537.GA14570@lerouge> (raw)
In-Reply-To: <20141022123547.GL12706@worktop.programming.kicks-ass.net>
On Wed, Oct 22, 2014 at 02:35:47PM +0200, Peter Zijlstra wrote:
> On Mon, Oct 13, 2014 at 04:45:30PM +0300, Alexander Shishkin wrote:
> > + struct kref aux_refcount;
>
> I'm not a fan of kref, pointless obfuscation that.
It has a good potential for debugging though. Sure right now
the get/put simple APIs only performs counting sanity checks
but I've seen patches that extend it to object debugging.
Sounds quite valuable on complicated object lifecycles like
perf events.
next prev parent reply other threads:[~2014-10-23 3:05 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 13:45 [PATCH v5 00/20] perf: Add infrastructure and support for Intel PT Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 01/20] perf: Add data_{offset,size} to user_page Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams Alexander Shishkin
2014-10-22 12:35 ` Peter Zijlstra
2014-10-23 3:05 ` Frederic Weisbecker [this message]
2014-10-13 13:45 ` [PATCH v5 03/20] perf: Support high-order allocations for AUX space Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 04/20] perf: Add a capability for AUX_NO_SG pmus to do software double buffering Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 05/20] perf: Add a pmu capability for "exclusive" events Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 06/20] perf: Add AUX record Alexander Shishkin
2014-10-22 13:26 ` Peter Zijlstra
2014-10-22 14:18 ` Alexander Shishkin
2014-10-22 15:07 ` Peter Zijlstra
2014-10-13 13:45 ` [PATCH v5 07/20] perf: Add api for pmus to write to AUX area Alexander Shishkin
2014-10-22 14:02 ` Peter Zijlstra
2014-10-22 14:14 ` Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 08/20] perf: Support overwrite mode for " Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 09/20] perf: Add wakeup watermark control to " Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 10/20] x86: Add Intel Processor Trace (INTEL_PT) cpu feature detection Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 11/20] x86: perf: Intel PT and LBR/BTS are mutually exclusive Alexander Shishkin
2014-10-22 14:15 ` Peter Zijlstra
2014-10-24 7:47 ` Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver Alexander Shishkin
2014-10-22 14:17 ` Peter Zijlstra
2014-10-22 14:20 ` Peter Zijlstra
2014-10-24 7:49 ` Alexander Shishkin
2014-10-24 11:26 ` Peter Zijlstra
2014-10-24 12:01 ` Alexander Shishkin
2014-10-22 14:23 ` Peter Zijlstra
2014-10-22 14:27 ` Peter Zijlstra
2014-10-24 7:50 ` Alexander Shishkin
2014-10-22 14:32 ` Peter Zijlstra
2014-10-31 13:13 ` Alexander Shishkin
2014-11-04 15:57 ` Peter Zijlstra
2014-11-11 11:24 ` Alexander Shishkin
2014-11-11 13:20 ` Peter Zijlstra
2014-11-11 14:17 ` Alexander Shishkin
2014-10-22 14:34 ` Peter Zijlstra
2014-10-24 7:52 ` Alexander Shishkin
2014-10-22 14:45 ` Peter Zijlstra
2014-10-24 8:22 ` Alexander Shishkin
2014-10-24 11:51 ` Peter Zijlstra
2014-10-24 12:13 ` Alexander Shishkin
2014-10-24 13:02 ` Peter Zijlstra
2014-10-24 13:18 ` Alexander Shishkin
2014-10-24 13:48 ` Peter Zijlstra
2014-10-22 14:49 ` Peter Zijlstra
2014-10-22 15:11 ` Peter Zijlstra
2014-10-22 14:55 ` Peter Zijlstra
2014-10-24 7:59 ` Alexander Shishkin
2014-10-22 15:14 ` Peter Zijlstra
2014-10-24 7:59 ` Alexander Shishkin
2014-10-22 15:26 ` Peter Zijlstra
2014-10-13 13:45 ` [PATCH v5 13/20] x86: perf: intel_bts: Add BTS " Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 14/20] perf: add ITRACE_START record to indicate that tracing has started Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 15/20] perf: Add api to (de-)allocate AUX buffers for kernel counters Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 16/20] perf: Add a helper for looking up pmus by type Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 17/20] perf: Add infrastructure for using AUX data in perf samples Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 18/20] perf: Allocate ring buffers for inherited per-task kernel events Alexander Shishkin
2014-10-23 12:38 ` Peter Zijlstra
2014-10-24 7:44 ` Alexander Shishkin
2014-10-30 8:43 ` Peter Zijlstra
2014-10-30 10:20 ` Alexander Shishkin
2014-10-30 13:31 ` Arnaldo Carvalho de Melo
2014-10-13 13:45 ` [PATCH v5 19/20] perf: Allow AUX sampling for multiple events Alexander Shishkin
2014-10-13 13:45 ` [PATCH v5 20/20] perf: Allow AUX sampling of inherited events Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023030537.GA14570@lerouge \
--to=fweisbec@gmail.com \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox