From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eric Rost <eric.rost@mybabylon.net>
Cc: gregkh@linuxfoundation.org, jason@lakedaemon.net, jake@lwn.net,
antonysaraev@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: skein: Add Loadable Module Support
Date: Thu, 23 Oct 2014 15:33:51 +0300 [thread overview]
Message-ID: <20141023123351.GQ23154@mwanda> (raw)
In-Reply-To: <6465068320badb589bcbd2cf37f4700e2cef0406.1414030776.git.eric.rost@mybabylon.net>
On Wed, Oct 22, 2014 at 09:24:37PM -0500, Eric Rost wrote:
> +static int __init skein_generic_mod_init(void)
> +{
> + return crypto_register_shash(&alg256) || crypto_register_shash(&alg512)
> + || crypto_register_shash(&alg1024);
Shouldn't it unwind on error?
> +}
regards,
dan carpenter
prev parent reply other threads:[~2014-10-23 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 2:22 [PATCH v2 0/2] staging: skein: Add Crypto API and Loadable Module support Eric Rost
2014-10-23 2:23 ` [PATCH v2 1/2] staging: skein: Add Crypto API support Eric Rost
2014-10-23 12:28 ` Dan Carpenter
2014-10-23 12:51 ` Jason Cooper
2014-10-23 12:42 ` Jason Cooper
2014-10-23 2:24 ` [PATCH v2 2/2] staging: skein: Add Loadable Module Support Eric Rost
2014-10-23 12:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023123351.GQ23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=antonysaraev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric.rost@mybabylon.net \
--cc=gregkh@linuxfoundation.org \
--cc=jake@lwn.net \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox