Re: [PATCH v2 1/3] add sysfs document for fpga bridges

Pavel Machek
2014-10-29T08:25:48Z

On Fri 2014-10-24 10:11:26, atull wrote:
> On Fri, 24 Oct 2014, Pavel Machek wrote:
>
> > On Thu 2014-10-23 18:51:05, atull@opensource.altera.com wrote:
> > > From: Alan Tull <atull@opensource.altera.com>
> > >
> > > Add sysfs document for fpga bridges.
> > >
> > > --- /dev/null
> > > +++ b/Documentation/ABI/testing/sysfs-class-fpga-bridge
> > > @@ -0,0 +1,5 @@
> > > +What: /sys/class/fpga-bridge/<bridge>/enable
> > > +Date: October 2014
> > > +KernelVersion: 3.18
> > > +Contact: Alan Tull <atull@opensource.altera.com>
> > > +Description: Enable bridge. Write 1 to bring bridge out of reset.
> >
> > Specify, what happens when 0 is written there?
>
> Yes, I will add: 'Write 0 has no effect.'

Definitely add it, then. The way it is written, I'd expect 0 to put
bridge into reset.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html