Re: [PATCH v2 2/3] ARM: dts: socfpga: fpga bridges bindings docs

Pantelis Antoniou
2014-10-27T15:05:39Z

Hi Mark,

> On Oct 27, 2014, at 17:01 , Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Oct 27, 2014 at 01:48:02PM +0200, Pantelis Antoniou wrote:
>>> On Oct 24, 2014, at 02:51 , atull@opensource.altera.com wrote:
>
>>> + - init-val : 0 if driver should disable bridge at startup
>>> + 1 if driver should enable bridge at startup
>>> + driver leaves bridge in current state if property not
>>> + specified.
>
>> Isn’t init-val a boolean property? It’s not named very well.
>
> It's not boolean, it's tristate - turn on, turn off or don't touch.
>

I see. Even then ‘init-val’ is cryptic. I’d prefer two booleans,
enable-at-startup; disable-at-startup.

>> Along with the label, is kinda hard to defend as configuration in DT.
>
> Yeah... presumably this decision would fall out of the users?

Well, it’s the user that should make the decision, but the driver should
pick it up. This works but it’s not very nice.

Regards

— Pantelis