From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, nicolas.pitre@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed
Date: Fri, 24 Oct 2014 15:56:06 +0200 [thread overview]
Message-ID: <20141024135606.GD21513@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <544A5799.7020405@linaro.org>
On Fri, Oct 24, 2014 at 03:43:53PM +0200, Daniel Lezcano wrote:
> On 10/24/2014 03:38 PM, Peter Zijlstra wrote:
> >On Mon, Oct 20, 2014 at 06:25:41PM +0200, Daniel Lezcano wrote:
> >>+++ b/kernel/sched/idle.c
> >>@@ -162,7 +162,8 @@ use_default:
> >> /*
> >> * Give the governor an opportunity to reflect on the outcome
> >> */
> >>- cpuidle_reflect(dev, entered_state);
> >>+ if (entered_state >= 0)
> >>+ cpuidle_reflect(dev, entered_state);
> >>
> >
> >Given we'll do use_default: when next_state < 0, we actually never get
> >here unless this is true.
>
> There is the 'cpuidle_enter' call in between which may fail.
Hmm, indeed there is. I had not expected that one to fail like this.
next prev parent reply other threads:[~2014-10-24 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 16:25 [PATCH 1/5] sched: idle: cpuidle: Check the latency req before idle Daniel Lezcano
2014-10-20 16:25 ` [PATCH 2/5] sched: idle: Get the next timer event and pass it the cpuidle framework Daniel Lezcano
2014-10-22 20:38 ` Nicolas Pitre
2014-10-28 1:53 ` Len Brown
2014-10-28 6:40 ` Preeti Murthy
2014-10-28 18:02 ` Daniel Lezcano
2014-10-20 16:25 ` [PATCH 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed Daniel Lezcano
2014-10-22 20:41 ` Nicolas Pitre
2014-10-24 13:24 ` Peter Zijlstra
2014-10-24 13:32 ` Daniel Lezcano
2014-10-24 13:38 ` Peter Zijlstra
2014-10-24 13:43 ` Daniel Lezcano
2014-10-24 13:56 ` Peter Zijlstra [this message]
2014-10-20 16:25 ` [PATCH 4/5] cpuidle: menu: Fix the get_typical_interval Daniel Lezcano
2014-10-20 16:25 ` [PATCH 5/5] cpuidle: menu: Move the update function before its declaration Daniel Lezcano
2014-10-22 20:30 ` [PATCH 1/5] sched: idle: cpuidle: Check the latency req before idle Nicolas Pitre
2014-10-27 22:58 ` Rafael J. Wysocki
2014-10-28 8:30 ` Peter Zijlstra
2014-10-28 1:49 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024135606.GD21513@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox