From: Peter Zijlstra <peterz@infradead.org>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Brown, Len" <len.brown@intel.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
"linux-pm@vger.kernel.org >> Linux PM list"
<linux-pm@vger.kernel.org>
Subject: Re: [RFC/PATCH] PM / Sleep: Timer quiesce in freeze state
Date: Mon, 27 Oct 2014 08:44:19 +0100 [thread overview]
Message-ID: <20141027074419.GE10501@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <544DE5CF.9040501@linux.intel.com>
On Mon, Oct 27, 2014 at 02:27:27PM +0800, Li, Aubrey wrote:
> >> +static void freezer_suspend_tk(int cpu)
> >> {
> >> + if (tick_do_timer_cpu != cpu)
> >> + return;
> >> +
> >
> > I had a note here that this might be broken for clocksource drivers that
> > have suspend/resume methods. You seem to have 'lost' that note, is that
> > because you found it isn't a problem?
> >
> I don't see it's a problem as long as we do not refer the clock source
> before it resumes. But I think my testing didn't cover that case that
> clock source drivers have suspend/resume methods. Can you please give
> more details what do you worry about?
I can't seem to recall :/ Maybe I conflated clocksource and clockevents
and figured we'd need to run the clocksource suspend callback on each
cpu.
next prev parent reply other threads:[~2014-10-27 7:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:15 [RFC/PATCH] PM / Sleep: Timer quiesce in freeze state Li, Aubrey
2014-10-24 15:36 ` Peter Zijlstra
2014-10-27 6:27 ` Li, Aubrey
2014-10-27 7:28 ` Peter Zijlstra
2014-10-28 4:32 ` Li, Aubrey
2014-10-28 8:29 ` Peter Zijlstra
2014-10-28 22:46 ` Li, Aubrey
2014-10-29 8:21 ` Peter Zijlstra
2014-10-29 15:09 ` Li, Aubrey
2014-10-27 7:44 ` Peter Zijlstra [this message]
2014-10-28 7:52 ` Li, Aubrey
2014-10-28 8:25 ` Peter Zijlstra
2014-10-28 23:22 ` Li, Aubrey
2014-10-29 8:24 ` Peter Zijlstra
2014-10-30 2:58 ` [PATCH v2] " Li, Aubrey
2014-11-08 2:05 ` Rafael J. Wysocki
2014-11-10 11:49 ` Peter Zijlstra
2014-11-12 21:09 ` Thomas Gleixner
2014-11-13 1:37 ` Peter Zijlstra
2014-11-13 2:20 ` Li, Aubrey
2014-11-13 9:19 ` Thomas Gleixner
2014-11-13 10:50 ` Li, Aubrey
2014-11-13 9:10 ` Thomas Gleixner
2014-11-13 10:47 ` Li, Aubrey
2014-11-13 13:06 ` Thomas Gleixner
2014-11-14 7:58 ` Li, Aubrey
2014-10-28 4:39 ` [RFC/PATCH] " Li, Aubrey
2014-10-28 8:25 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027074419.GE10501@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).