From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752036AbaJ0IvD (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Oct 2014 04:51:03 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:49409 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750761AbaJ0IvA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Oct 2014 04:51:00 -0400
Date: Mon, 27 Oct 2014 09:50:48 +0100
From: Richard Cochran <richardcochran@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/15] net: dsa: Add support for switch EEPROM access
Message-ID: <20141027085048.GC4748@netboy>
References: <1414342365-27191-1-git-send-email-linux@roeck-us.net>
 <1414342365-27191-10-git-send-email-linux@roeck-us.net>
 <20141027024121.GA16998@lunn.ch>
 <544DC264.9020600@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <544DC264.9020600@roeck-us.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 26, 2014 at 08:56:20PM -0700, Guenter Roeck wrote:
> 
> Also, it seems that you request two separate properties, one for presence
> and another for length. Is that correct ? Again, I thought that would not
> provide any value since presence is indicated by length != 0 in the ethtool
> callback function. No problem, though, I'll be happy to create two separate
> properties and platform data variables if you think that would be better.

The fewer properties, the better.

Thanks,
Richard