From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Yao Dongdong <yaodongdong@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched:skip loop non-idle cpus after find an idle cpu while find_idlest_cpu
Date: Mon, 27 Oct 2014 14:53:17 +0530 [thread overview]
Message-ID: <20141027092317.GC10867@linux.vnet.ibm.com> (raw)
In-Reply-To: <544E091D.9040102@huawei.com>
* Yao Dongdong <yaodongdong@huawei.com> [2014-10-27 16:58:05]:
> On 2014/10/27 16:04, Srikar Dronamraju wrote:
> > * Yao Dongdong <yaodongdong@huawei.com> [2014-10-27 11:13:17]:
> >
> >> Idle cpu is idler than non-idle cpu, so we needn't loop non-idle cpus after find an idle cpu.
> >>
> > While this check looks good,
> > I dont see how we are avoiding a loop?
> >
> > Are you suggesting that we break of the for loop once we set
> > shallowest_idle_cpu?
> >
> Thanks for your review.
>
> I agree that the submit message is a bit misleading, what this patch do is just avoiding search for least_loaded_cpu
> in non-idle cpus.
>
> sched:add check of shallowest_idle_cpu before search for least_loaded_cpu
>
> Idle cpu is idler than non-idle cpu, so we needn't search for least_loaded_cpu
> after we have found an idle cpu.
>
Looks good for me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2014-10-27 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 3:13 [PATCH] sched:skip loop non-idle cpus after find an idle cpu while find_idlest_cpu Yao Dongdong
2014-10-27 8:04 ` Srikar Dronamraju
2014-10-27 8:58 ` Yao Dongdong
2014-10-27 9:23 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027092317.GC10867@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yaodongdong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox