From: Dan Carpenter <dan.carpenter@oracle.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] regulator: max77802: fix a test in max77802_set_suspend_mode()
Date: Mon, 27 Oct 2014 13:45:06 +0300 [thread overview]
Message-ID: <20141027104506.GA22704@mwanda> (raw)
In-Reply-To: <71442C69-B48C-46B8-93A1-068AC26E01C2@collabora.co.uk>
The original test triggers a static checker warning. Javier Martinez
Canillas says that the "!" is a typo and should be removed.
Fixes: 2e0eaa1aa008 ('regulator: max77802: Add set suspend mode for BUCKs and simplify code')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: The first version of this patch was buggy. Thanks Javier for
your review.
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c
index 5839c45..7718c8a 100644
--- a/drivers/regulator/max77802.c
+++ b/drivers/regulator/max77802.c
@@ -179,7 +179,7 @@ static int max77802_set_suspend_mode(struct regulator_dev *rdev,
* If the regulator has been disabled for suspend
* then is invalid to try setting a suspend mode.
*/
- if (!max77802->opmode[id] == MAX77802_OFF_PWRREQ) {
+ if (max77802->opmode[id] == MAX77802_OFF_PWRREQ) {
dev_warn(&rdev->dev, "%s: is disabled, mode: 0x%x not set\n",
rdev->desc->name, mode);
return 0;
next prev parent reply other threads:[~2014-10-27 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 8:16 [patch] regulator: max77802: precedence error in max77802_set_suspend_mode() Dan Carpenter
2014-10-24 9:04 ` Javier Martinez Canillas
2014-10-27 10:45 ` Dan Carpenter [this message]
2014-10-27 13:21 ` [patch v2] regulator: max77802: fix a test " Javier Martinez Canillas
2014-10-27 18:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027104506.GA22704@mwanda \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox