From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8712: remove unused variables
Date: Mon, 27 Oct 2014 15:12:57 +0300 [thread overview]
Message-ID: <20141027121256.GF6879@mwanda> (raw)
In-Reply-To: <20141027115221.GA5369@sudip-PC>
On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote:
> On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote:
> > On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote:
> > > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
> > > if (tmp8_a != (tmp8|BIT(2)))
> > > goto exit_fail;
> > >
> > > - tmp32 = r8712_read32(padapter, TCR);
> > > + r8712_read32(padapter, TCR);
> >
> > I wonder if we actually need to call r8712_read32() here? It's not
> > clear. The changelog should say one way or the other. Maybe something
> > like "I left a call to r8712_read32(padapter, TCR) because I didn't know
> > if it had side effects". When you note down questions you have in the
> > changelog that helps reviewers.
> sure. i will resend it with modified commit log.
> r8712_read32() is ultimately calling usb_read32() which is again calling r8712_usbctrl_vendorreq().
> this r8712_usbctrl_vendorreq() is communicating through the usb bus and is sending and receiving the control msg.
> that is why i didnot remove it.
Yeah. I'm 95% sure it's not needed, but I suppose it's better to err
on the side of caution.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-27 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 12:33 [PATCH] staging: rtl8712: remove unused variables Sudip Mukherjee
2014-10-27 11:13 ` Dan Carpenter
2014-10-27 11:52 ` Sudip Mukherjee
2014-10-27 12:12 ` Dan Carpenter [this message]
2014-10-27 12:18 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027121256.GF6879@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox