From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752772AbaJ0Osv (ORCPT ); Mon, 27 Oct 2014 10:48:51 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:47112 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbaJ0Osu (ORCPT ); Mon, 27 Oct 2014 10:48:50 -0400 Date: Mon, 27 Oct 2014 15:48:42 +0100 From: Peter Zijlstra To: Andi Kleen Cc: Andi Kleen , mingo@kernel.org, tglx@linutronix.de, eranian@google.com, dzickus@redhat.com, jmario@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] Attempt to cleanup the HSW offcore bits Message-ID: <20141027144842.GG10501@worktop.programming.kicks-ass.net> References: <20141023105119.173457103@infradead.org> <20141027122340.GU12538@two.firstfloor.org> <20141027130712.GF3337@twins.programming.kicks-ass.net> <20141027142818.GA3041@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141027142818.GA3041@tassilo.jf.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 27, 2014 at 07:28:18AM -0700, Andi Kleen wrote: > On Mon, Oct 27, 2014 at 02:07:12PM +0100, Peter Zijlstra wrote: > > On Mon, Oct 27, 2014 at 01:23:40PM +0100, Andi Kleen wrote: > > > On Thu, Oct 23, 2014 at 12:51:19PM +0200, Peter Zijlstra wrote: > > > > So Don asked about offcore and because I forgot I looked at the code and found > > > > the terrible mess Andi created with the HSW/BDW bits. > > > > > > > > This series attempts to clean some of that up but seeing how it was all magic > > > > numbers > > > > > > All the bits are documented. The actual definitions are available > > > in the JSON offcore definitions at https://download.01.org/perfmon/ > > > > Yeah, no. That's not how we write code. Also, there's no actual JSON > > offcore file for HSW only some TSV file, and I've no mind to go decode > > https://download.01.org/perfmon/HSW/Haswell_matrix_V14.json > https://download.01.org/perfmon/HSW/Haswell_matrix_bit_definitions_V14.json So you expected me to somehow magically know it was not the file with offcore in its name then?