From: Al Viro <viro@ZenIV.linux.org.uk>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH v3.18-rc2] staging: android: logger: Fix log corruption regression
Date: Mon, 27 Oct 2014 18:59:22 +0000 [thread overview]
Message-ID: <20141027185922.GX7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1414435903-20002-1-git-send-email-daniel.thompson@linaro.org>
On Mon, Oct 27, 2014 at 06:51:43PM +0000, Daniel Thompson wrote:
> Since commit cd678fce4280 ("switch logger to ->write_iter()"), any
> attempt to write to the log results in the log data being written over
> its own metadata, thus rendering the log unreadable.
>
> The problem was first detected when I ran an Android userspace on the
> v3.18-rc1 kernel. However the issue can also be observed with a
> non-Android userspace by using echo/cat to write to/from /dev/log_main .
>
> This patch resolves the problem by using a temporary to track the status
> of not-yet-committed writes to the log buffer.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
Applied
prev parent reply other threads:[~2014-10-27 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 18:51 [PATCH v3.18-rc2] staging: android: logger: Fix log corruption regression Daniel Thompson
2014-10-27 18:59 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027185922.GX7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=daniel.thompson@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox