From: Ingo Molnar <mingo@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: tglx@linutronix.de, jiang.liu@linux.intel.com,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
Date: Wed, 29 Oct 2014 08:59:15 +0100 [thread overview]
Message-ID: <20141029075915.GB7322@gmail.com> (raw)
In-Reply-To: <5450AAF30200007800042F64@mail.emea.novell.com>
* Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 29.10.14 at 08:50, <mingo@kernel.org> wrote:
>
> > * Jan Beulich <JBeulich@suse.com> wrote:
> >
> >> >>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
> >> > Commit-ID: a425cf83e39f99a70168c184e79cea8c67ba7c12
> >> > Gitweb:
> > http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12
> >> > Author: Jan Beulich <JBeulich@suse.com>
> >> > AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
> >> > Committer: Ingo Molnar <mingo@kernel.org>
> >> > CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
> >> >
> >> > ix86: Fix build failure when !CONFIG_X86_IO_APIC
> >> >
> >> > mp_should_keep_irq() isn't really IO-APIC related, and
> >> > considering that it's being used solely in arch/x86/pci/ likely
> >> > both declaration and definition got misplaced even without
> >> > considering the resulting build failure:
> >> >
> >> > .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
> >> > .../arch/x86/pci/irq.c:1259: error: implicit declaration of function
> >> > ‘mp_should_keep_irq’
> >> > make[3]: *** [arch/x86/pci/irq.o] Error 1
> >> >
> >> > Move them to better places.
> >>
> >> Ingo,
> >>
> >> the build failure had got addressed by a different patch
> >> already, albeit that patch seems far from ideal to me. I.e. I
> >> still think cleanup along the lines of the patch here is
> >> desirable, but I need to submit one that actually builds (the
> >> build failure the test robot encountered is a direct result of
> >> the clash between the two patches). I have that patch ready,
> >> but didn't want to submit before I got around to test it with
> >> 3.18-rc.
> >
> > Okay, I've removed it from x86/urgent. Note that it also
> > generated this build failure:
> >
> > ./arch/x86/include/asm/io_apic.h:240:20: error: static declaration of
> > ‘mp_should_keep_irq’ follows non-static declaration
>
> Right - that's the one I was referring to above (actually iirc there
> are two relatively similar build failures resulting from the conflict).
Okay. I didn't mind your cleanup, so please follow it up and I'll
apply it.
Thanks,
Ingo
prev parent reply other threads:[~2014-10-29 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:44 [PATCH] ix86: fix build failure when !CONFIG_X86_IO_APIC Jan Beulich
2014-10-28 11:13 ` [tip:x86/urgent] ix86: Fix " tip-bot for Jan Beulich
2014-10-28 11:18 ` tip-bot for Jan Beulich
2014-10-28 13:47 ` Jan Beulich
2014-10-29 7:50 ` Ingo Molnar
2014-10-29 7:53 ` Jan Beulich
2014-10-29 7:59 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029075915.GB7322@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox