public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ix86: fix build failure when !CONFIG_X86_IO_APIC
@ 2014-09-16 12:44 Jan Beulich
  2014-10-28 11:13 ` [tip:x86/urgent] ix86: Fix " tip-bot for Jan Beulich
  2014-10-28 11:18 ` tip-bot for Jan Beulich
  0 siblings, 2 replies; 7+ messages in thread
From: Jan Beulich @ 2014-09-16 12:44 UTC (permalink / raw)
  To: mingo, tglx, hpa; +Cc: jiang.liu, linux-kernel

mp_should_keep_irq() isn't really IO-APIC related, and considering that
it's being used solely in arch/x86/pci/ likely both declaration and
definition got misplaced even without considering the resulting build
failure:

.../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
.../arch/x86/pci/irq.c:1259: error: implicit declaration of function ‘mp_should_keep_irq’
make[3]: *** [arch/x86/pci/irq.o] Error 1

Move them to better places.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/x86/include/asm/io_apic.h |    2 --
 arch/x86/include/asm/pci_x86.h |    2 ++
 arch/x86/kernel/apic/io_apic.c |   12 ------------
 arch/x86/pci/irq.c             |   12 ++++++++++++
 4 files changed, 14 insertions(+), 14 deletions(-)

--- 3.17-rc5/arch/x86/include/asm/io_apic.h
+++ 3.17-rc5-ix86-build-no-IOAPIC/arch/x86/include/asm/io_apic.h
@@ -227,8 +227,6 @@ static inline void io_apic_modify(unsign
 
 extern void io_apic_eoi(unsigned int apic, unsigned int vector);
 
-extern bool mp_should_keep_irq(struct device *dev);
-
 #else  /* !CONFIG_X86_IO_APIC */
 
 #define io_apic_assign_pci_irqs 0
--- 3.17-rc5/arch/x86/include/asm/pci_x86.h
+++ 3.17-rc5-ix86-build-no-IOAPIC/arch/x86/include/asm/pci_x86.h
@@ -93,6 +93,8 @@ extern raw_spinlock_t pci_config_lock;
 extern int (*pcibios_enable_irq)(struct pci_dev *dev);
 extern void (*pcibios_disable_irq)(struct pci_dev *dev);
 
+extern bool mp_should_keep_irq(struct device *dev);
+
 struct pci_raw_ops {
 	int (*read)(unsigned int domain, unsigned int bus, unsigned int devfn,
 						int reg, int len, u32 *val);
--- 3.17-rc5/arch/x86/kernel/apic/io_apic.c
+++ 3.17-rc5-ix86-build-no-IOAPIC/arch/x86/kernel/apic/io_apic.c
@@ -3959,18 +3959,6 @@ int mp_set_gsi_attr(u32 gsi, int trigger
 	return ret;
 }
 
-bool mp_should_keep_irq(struct device *dev)
-{
-	if (dev->power.is_prepared)
-		return true;
-#ifdef	CONFIG_PM_RUNTIME
-	if (dev->power.runtime_status == RPM_SUSPENDING)
-		return true;
-#endif
-
-	return false;
-}
-
 /* Enable IOAPIC early just for system timer */
 void __init pre_init_apic_IRQ0(void)
 {
--- 3.17-rc5/arch/x86/pci/irq.c
+++ 3.17-rc5-ix86-build-no-IOAPIC/arch/x86/pci/irq.c
@@ -1254,6 +1254,18 @@ static int pirq_enable_irq(struct pci_de
 	return 0;
 }
 
+bool mp_should_keep_irq(struct device *dev)
+{
+	if (dev->power.is_prepared)
+		return true;
+#ifdef CONFIG_PM_RUNTIME
+	if (dev->power.runtime_status == RPM_SUSPENDING)
+		return true;
+#endif
+
+	return false;
+}
+
 static void pirq_disable_irq(struct pci_dev *dev)
 {
 	if (io_apic_assign_pci_irqs && !mp_should_keep_irq(&dev->dev) &&



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-09-16 12:44 [PATCH] ix86: fix build failure when !CONFIG_X86_IO_APIC Jan Beulich
@ 2014-10-28 11:13 ` tip-bot for Jan Beulich
  2014-10-28 11:18 ` tip-bot for Jan Beulich
  1 sibling, 0 replies; 7+ messages in thread
From: tip-bot for Jan Beulich @ 2014-10-28 11:13 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, tglx, mingo, JBeulich, jbeulich, hpa, jiang.liu

Commit-ID:  de8bf1a32bd379a4f953c3146b82c8a438d7aa5d
Gitweb:     http://git.kernel.org/tip/de8bf1a32bd379a4f953c3146b82c8a438d7aa5d
Author:     Jan Beulich <JBeulich@suse.com>
AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 28 Oct 2014 11:06:16 +0100

ix86: Fix build failure when !CONFIG_X86_IO_APIC

mp_should_keep_irq() isn't really IO-APIC related, and
considering that it's being used solely in arch/x86/pci/ likely
both declaration and definition got misplaced even without
considering the resulting build failure:

  .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
  .../arch/x86/pci/irq.c:1259: error: implicit declaration of function ‘mp_should_keep_irq’
  make[3]: *** [arch/x86/pci/irq.o] Error 1

Move them to better places.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Link: http://lkml.kernel.org/r/54184CC802000078000355EE@mail.emea.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/io_apic.h |  2 --
 arch/x86/include/asm/pci_x86.h |  2 ++
 arch/x86/kernel/apic/io_apic.c | 12 ------------
 arch/x86/pci/irq.c             | 12 ++++++++++++
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h
index 1733ab4..51b25f5 100644
--- a/arch/x86/include/asm/io_apic.h
+++ b/arch/x86/include/asm/io_apic.h
@@ -227,8 +227,6 @@ static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned
 
 extern void io_apic_eoi(unsigned int apic, unsigned int vector);
 
-extern bool mp_should_keep_irq(struct device *dev);
-
 #else  /* !CONFIG_X86_IO_APIC */
 
 #define io_apic_assign_pci_irqs 0
diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
index fa1195d..164e3f8 100644
--- a/arch/x86/include/asm/pci_x86.h
+++ b/arch/x86/include/asm/pci_x86.h
@@ -93,6 +93,8 @@ extern raw_spinlock_t pci_config_lock;
 extern int (*pcibios_enable_irq)(struct pci_dev *dev);
 extern void (*pcibios_disable_irq)(struct pci_dev *dev);
 
+extern bool mp_should_keep_irq(struct device *dev);
+
 struct pci_raw_ops {
 	int (*read)(unsigned int domain, unsigned int bus, unsigned int devfn,
 						int reg, int len, u32 *val);
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 1183d54..d3ad43b 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3964,18 +3964,6 @@ int mp_set_gsi_attr(u32 gsi, int trigger, int polarity, int node)
 	return ret;
 }
 
-bool mp_should_keep_irq(struct device *dev)
-{
-	if (dev->power.is_prepared)
-		return true;
-#ifdef	CONFIG_PM_RUNTIME
-	if (dev->power.runtime_status == RPM_SUSPENDING)
-		return true;
-#endif
-
-	return false;
-}
-
 /* Enable IOAPIC early just for system timer */
 void __init pre_init_apic_IRQ0(void)
 {
diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
index eb500c2..cb50e28 100644
--- a/arch/x86/pci/irq.c
+++ b/arch/x86/pci/irq.c
@@ -1254,6 +1254,18 @@ static int pirq_enable_irq(struct pci_dev *dev)
 	return 0;
 }
 
+bool mp_should_keep_irq(struct device *dev)
+{
+	if (dev->power.is_prepared)
+		return true;
+#ifdef CONFIG_PM_RUNTIME
+	if (dev->power.runtime_status == RPM_SUSPENDING)
+		return true;
+#endif
+
+	return false;
+}
+
 static void pirq_disable_irq(struct pci_dev *dev)
 {
 	if (io_apic_assign_pci_irqs && !mp_should_keep_irq(&dev->dev) &&

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-09-16 12:44 [PATCH] ix86: fix build failure when !CONFIG_X86_IO_APIC Jan Beulich
  2014-10-28 11:13 ` [tip:x86/urgent] ix86: Fix " tip-bot for Jan Beulich
@ 2014-10-28 11:18 ` tip-bot for Jan Beulich
  2014-10-28 13:47   ` Jan Beulich
  1 sibling, 1 reply; 7+ messages in thread
From: tip-bot for Jan Beulich @ 2014-10-28 11:18 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: jiang.liu, tglx, mingo, linux-kernel, jbeulich, JBeulich, hpa

Commit-ID:  a425cf83e39f99a70168c184e79cea8c67ba7c12
Gitweb:     http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12
Author:     Jan Beulich <JBeulich@suse.com>
AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 28 Oct 2014 12:01:09 +0100

ix86: Fix build failure when !CONFIG_X86_IO_APIC

mp_should_keep_irq() isn't really IO-APIC related, and
considering that it's being used solely in arch/x86/pci/ likely
both declaration and definition got misplaced even without
considering the resulting build failure:

  .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
  .../arch/x86/pci/irq.c:1259: error: implicit declaration of function ‘mp_should_keep_irq’
  make[3]: *** [arch/x86/pci/irq.o] Error 1

Move them to better places.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Link: http://lkml.kernel.org/r/54184CC802000078000355EE@mail.emea.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/io_apic.h |  2 --
 arch/x86/include/asm/pci_x86.h |  2 ++
 arch/x86/kernel/apic/io_apic.c | 12 ------------
 arch/x86/pci/irq.c             | 12 ++++++++++++
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h
index 1733ab4..51b25f5 100644
--- a/arch/x86/include/asm/io_apic.h
+++ b/arch/x86/include/asm/io_apic.h
@@ -227,8 +227,6 @@ static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned
 
 extern void io_apic_eoi(unsigned int apic, unsigned int vector);
 
-extern bool mp_should_keep_irq(struct device *dev);
-
 #else  /* !CONFIG_X86_IO_APIC */
 
 #define io_apic_assign_pci_irqs 0
diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
index fa1195d..164e3f8 100644
--- a/arch/x86/include/asm/pci_x86.h
+++ b/arch/x86/include/asm/pci_x86.h
@@ -93,6 +93,8 @@ extern raw_spinlock_t pci_config_lock;
 extern int (*pcibios_enable_irq)(struct pci_dev *dev);
 extern void (*pcibios_disable_irq)(struct pci_dev *dev);
 
+extern bool mp_should_keep_irq(struct device *dev);
+
 struct pci_raw_ops {
 	int (*read)(unsigned int domain, unsigned int bus, unsigned int devfn,
 						int reg, int len, u32 *val);
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 1183d54..d3ad43b 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3964,18 +3964,6 @@ int mp_set_gsi_attr(u32 gsi, int trigger, int polarity, int node)
 	return ret;
 }
 
-bool mp_should_keep_irq(struct device *dev)
-{
-	if (dev->power.is_prepared)
-		return true;
-#ifdef	CONFIG_PM_RUNTIME
-	if (dev->power.runtime_status == RPM_SUSPENDING)
-		return true;
-#endif
-
-	return false;
-}
-
 /* Enable IOAPIC early just for system timer */
 void __init pre_init_apic_IRQ0(void)
 {
diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
index eb500c2..cb50e28 100644
--- a/arch/x86/pci/irq.c
+++ b/arch/x86/pci/irq.c
@@ -1254,6 +1254,18 @@ static int pirq_enable_irq(struct pci_dev *dev)
 	return 0;
 }
 
+bool mp_should_keep_irq(struct device *dev)
+{
+	if (dev->power.is_prepared)
+		return true;
+#ifdef CONFIG_PM_RUNTIME
+	if (dev->power.runtime_status == RPM_SUSPENDING)
+		return true;
+#endif
+
+	return false;
+}
+
 static void pirq_disable_irq(struct pci_dev *dev)
 {
 	if (io_apic_assign_pci_irqs && !mp_should_keep_irq(&dev->dev) &&

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-10-28 11:18 ` tip-bot for Jan Beulich
@ 2014-10-28 13:47   ` Jan Beulich
  2014-10-29  7:50     ` Ingo Molnar
  0 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2014-10-28 13:47 UTC (permalink / raw)
  To: mingo; +Cc: tglx, jiang.liu, linux-kernel, hpa

>>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
> Commit-ID:  a425cf83e39f99a70168c184e79cea8c67ba7c12
> Gitweb:     http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12 
> Author:     Jan Beulich <JBeulich@suse.com>
> AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
> 
> ix86: Fix build failure when !CONFIG_X86_IO_APIC
> 
> mp_should_keep_irq() isn't really IO-APIC related, and
> considering that it's being used solely in arch/x86/pci/ likely
> both declaration and definition got misplaced even without
> considering the resulting build failure:
> 
>   .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
>   .../arch/x86/pci/irq.c:1259: error: implicit declaration of function 
> ‘mp_should_keep_irq’
>   make[3]: *** [arch/x86/pci/irq.o] Error 1
> 
> Move them to better places.

Ingo,

the build failure had got addressed by a different patch already,
albeit that patch seems far from ideal to me. I.e. I still think cleanup
along the lines of the patch here is desirable, but I need to submit
one that actually builds (the build failure the test robot encountered
is a direct result of the clash between the two patches). I have that
patch ready, but didn't want to submit before I got around to test it
with 3.18-rc.

Jan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-10-28 13:47   ` Jan Beulich
@ 2014-10-29  7:50     ` Ingo Molnar
  2014-10-29  7:53       ` Jan Beulich
  0 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2014-10-29  7:50 UTC (permalink / raw)
  To: Jan Beulich; +Cc: tglx, jiang.liu, linux-kernel, hpa


* Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
> > Commit-ID:  a425cf83e39f99a70168c184e79cea8c67ba7c12
> > Gitweb:     http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12 
> > Author:     Jan Beulich <JBeulich@suse.com>
> > AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
> > 
> > ix86: Fix build failure when !CONFIG_X86_IO_APIC
> > 
> > mp_should_keep_irq() isn't really IO-APIC related, and
> > considering that it's being used solely in arch/x86/pci/ likely
> > both declaration and definition got misplaced even without
> > considering the resulting build failure:
> > 
> >   .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
> >   .../arch/x86/pci/irq.c:1259: error: implicit declaration of function 
> > ‘mp_should_keep_irq’
> >   make[3]: *** [arch/x86/pci/irq.o] Error 1
> > 
> > Move them to better places.
> 
> Ingo,
> 
> the build failure had got addressed by a different patch 
> already, albeit that patch seems far from ideal to me. I.e. I 
> still think cleanup along the lines of the patch here is 
> desirable, but I need to submit one that actually builds (the 
> build failure the test robot encountered is a direct result of 
> the clash between the two patches). I have that patch ready, 
> but didn't want to submit before I got around to test it with 
> 3.18-rc.

Okay, I've removed it from x86/urgent. Note that it also 
generated this build failure:

./arch/x86/include/asm/io_apic.h:240:20: error: static declaration of ‘mp_should_keep_irq’ follows non-static declaration

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-10-29  7:50     ` Ingo Molnar
@ 2014-10-29  7:53       ` Jan Beulich
  2014-10-29  7:59         ` Ingo Molnar
  0 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2014-10-29  7:53 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: tglx, jiang.liu, linux-kernel, hpa

>>> On 29.10.14 at 08:50, <mingo@kernel.org> wrote:

> * Jan Beulich <JBeulich@suse.com> wrote:
> 
>> >>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
>> > Commit-ID:  a425cf83e39f99a70168c184e79cea8c67ba7c12
>> > Gitweb:     
> http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12 
>> > Author:     Jan Beulich <JBeulich@suse.com>
>> > AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
>> > Committer:  Ingo Molnar <mingo@kernel.org>
>> > CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
>> > 
>> > ix86: Fix build failure when !CONFIG_X86_IO_APIC
>> > 
>> > mp_should_keep_irq() isn't really IO-APIC related, and
>> > considering that it's being used solely in arch/x86/pci/ likely
>> > both declaration and definition got misplaced even without
>> > considering the resulting build failure:
>> > 
>> >   .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
>> >   .../arch/x86/pci/irq.c:1259: error: implicit declaration of function 
>> > ‘mp_should_keep_irq’
>> >   make[3]: *** [arch/x86/pci/irq.o] Error 1
>> > 
>> > Move them to better places.
>> 
>> Ingo,
>> 
>> the build failure had got addressed by a different patch 
>> already, albeit that patch seems far from ideal to me. I.e. I 
>> still think cleanup along the lines of the patch here is 
>> desirable, but I need to submit one that actually builds (the 
>> build failure the test robot encountered is a direct result of 
>> the clash between the two patches). I have that patch ready, 
>> but didn't want to submit before I got around to test it with 
>> 3.18-rc.
> 
> Okay, I've removed it from x86/urgent. Note that it also 
> generated this build failure:
> 
> ./arch/x86/include/asm/io_apic.h:240:20: error: static declaration of 
> ‘mp_should_keep_irq’ follows non-static declaration

Right - that's the one I was referring to above (actually iirc there
are two relatively similar build failures resulting from the conflict).

Jan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [tip:x86/urgent] ix86: Fix build failure when !CONFIG_X86_IO_APIC
  2014-10-29  7:53       ` Jan Beulich
@ 2014-10-29  7:59         ` Ingo Molnar
  0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2014-10-29  7:59 UTC (permalink / raw)
  To: Jan Beulich; +Cc: tglx, jiang.liu, linux-kernel, hpa


* Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 29.10.14 at 08:50, <mingo@kernel.org> wrote:
> 
> > * Jan Beulich <JBeulich@suse.com> wrote:
> > 
> >> >>> On 28.10.14 at 12:18, <tipbot@zytor.com> wrote:
> >> > Commit-ID:  a425cf83e39f99a70168c184e79cea8c67ba7c12
> >> > Gitweb:     
> > http://git.kernel.org/tip/a425cf83e39f99a70168c184e79cea8c67ba7c12 
> >> > Author:     Jan Beulich <JBeulich@suse.com>
> >> > AuthorDate: Tue, 16 Sep 2014 13:44:24 +0100
> >> > Committer:  Ingo Molnar <mingo@kernel.org>
> >> > CommitDate: Tue, 28 Oct 2014 12:01:09 +0100
> >> > 
> >> > ix86: Fix build failure when !CONFIG_X86_IO_APIC
> >> > 
> >> > mp_should_keep_irq() isn't really IO-APIC related, and
> >> > considering that it's being used solely in arch/x86/pci/ likely
> >> > both declaration and definition got misplaced even without
> >> > considering the resulting build failure:
> >> > 
> >> >   .../arch/x86/pci/irq.c: In function ‘pirq_disable_irq’:
> >> >   .../arch/x86/pci/irq.c:1259: error: implicit declaration of function 
> >> > ‘mp_should_keep_irq’
> >> >   make[3]: *** [arch/x86/pci/irq.o] Error 1
> >> > 
> >> > Move them to better places.
> >> 
> >> Ingo,
> >> 
> >> the build failure had got addressed by a different patch 
> >> already, albeit that patch seems far from ideal to me. I.e. I 
> >> still think cleanup along the lines of the patch here is 
> >> desirable, but I need to submit one that actually builds (the 
> >> build failure the test robot encountered is a direct result of 
> >> the clash between the two patches). I have that patch ready, 
> >> but didn't want to submit before I got around to test it with 
> >> 3.18-rc.
> > 
> > Okay, I've removed it from x86/urgent. Note that it also 
> > generated this build failure:
> > 
> > ./arch/x86/include/asm/io_apic.h:240:20: error: static declaration of 
> > ‘mp_should_keep_irq’ follows non-static declaration
> 
> Right - that's the one I was referring to above (actually iirc there
> are two relatively similar build failures resulting from the conflict).

Okay. I didn't mind your cleanup, so please follow it up and I'll 
apply it.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-10-29  7:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 12:44 [PATCH] ix86: fix build failure when !CONFIG_X86_IO_APIC Jan Beulich
2014-10-28 11:13 ` [tip:x86/urgent] ix86: Fix " tip-bot for Jan Beulich
2014-10-28 11:18 ` tip-bot for Jan Beulich
2014-10-28 13:47   ` Jan Beulich
2014-10-29  7:50     ` Ingo Molnar
2014-10-29  7:53       ` Jan Beulich
2014-10-29  7:59         ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox