public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anton Saraev <antonysaraev@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	heenasirwani@gmail.com, bergwolf@gmail.com,
	amir.shehata@intel.com, gdonald@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/02] staging:lustre:lnet:selftest: fix sparse warnings
Date: Wed, 29 Oct 2014 16:37:30 +0800	[thread overview]
Message-ID: <20141029083730.GA16144@kroah.com> (raw)
In-Reply-To: <d5f02315b6e410bc677be4787762403cb3c75c2a.1414517099.git.antonysaraev@gmail.com>

On Tue, Oct 28, 2014 at 09:50:18PM +0400, Anton Saraev wrote:
> Fix sparse warnings: symbol X was not declared. Should it be static?
> Some functions used only in files where they are declared. They can
> be static.
> 
> Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/conctl.c    | 34 ++++++++--------
>  drivers/staging/lustre/lnet/selftest/conrpc.c    | 20 +++++-----
>  drivers/staging/lustre/lnet/selftest/framework.c | 50 ++++++++++++------------
>  drivers/staging/lustre/lnet/selftest/module.c    |  6 +--
>  drivers/staging/lustre/lnet/selftest/rpc.c       | 34 ++++++++--------
>  drivers/staging/lustre/lnet/selftest/timer.c     |  8 ++--
>  6 files changed, 76 insertions(+), 76 deletions(-)

This patch adds a build warning to the build, so I can't apply it.
Please fix it up and resend.

thanks,

greg k-h

  reply	other threads:[~2014-10-29 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  4:29 [PATCH 00/02] staging:lustre:lnet:selftest: fix sparse warnings Anton Saraev
2014-10-29  4:29 ` [PATCH 01/02] " Anton Saraev
2014-10-29  8:37   ` Greg KH [this message]
2014-10-29  4:29 ` [PATCH 02/02] staging:lustre:lnet:selftest: remove unused function Anton Saraev
2014-10-29  8:37   ` [PATCH v2 " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2014-10-29 19:41 [PATCH v2 00/02] staging:lustre:lnet:selftest: fix sparse warnings Anton Saraev
2014-10-29 19:41 ` [PATCH v2 01/02] " Anton Saraev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141029083730.GA16144@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amir.shehata@intel.com \
    --cc=andreas.dilger@intel.com \
    --cc=antonysaraev@gmail.com \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=heenasirwani@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox