Re: [RFC PATCH] gpio: add GPIO hogging mechanism

Greg Kroah-Hartman
2013-12-19T16:41:25Z

On Thu, Dec 19, 2013 at 03:34:31PM +0100, Boris BREZILLON wrote:
> GPIO hogging is a way to request and configure specific GPIO without
> explicitly requesting it in the device driver.
>
> The request and configuration procedure is handled in the core device
> driver code before the driver probe function is called.
>
> It allows specific GPIOs to be configured without any driver specific code.
>
> Particularly usefull when a external device is connected to a bus and the
> bus connections depends on an external switch controlled by a GPIO pin.
> Or when some GPIOs have to be exported to sysfs without any userspace
> intervention.
>
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio.txt | 47 ++++++++
> drivers/base/Makefile | 1 +
> drivers/base/dd.c | 5 +
> drivers/base/gpio.c | 59 ++++++++++

I don't understand what makes GPIO's "special" enough to get included in
the driver core like this, and called for each and every device that is
added to the system.

What's wrong with the generic device callbacks/notifiers we already
have? Why does this need to be in the driver core? And what exactly
are you doing all of this for in the first place?

greg k-h