[PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

[PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

[Tristan Lelong]

This patch removes tabs used to align variable names in declaration and assignation.
It replaces them with exactly one space.

Signed-off-by: Tristan Lelong <tristan.lelong@blunderer.org>
---
 drivers/staging/android/logger.c | 49 ++++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index 28b93d3..ce0b41d 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -50,20 +50,19 @@
  * mutex 'mutex'.
  */
 struct logger_log {
-	unsigned char		*buffer;
-	struct miscdevice	misc;
-	wait_queue_head_t	wq;
-	struct list_head	readers;
-	struct mutex		mutex;
-	size_t			w_off;
-	size_t			head;
-	size_t			size;
-	struct list_head	logs;
+	unsigned char *buffer;
+	struct miscdevice misc;
+	wait_queue_head_t wq;
+	struct list_head readers;
+	struct mutex mutex;
+	size_t w_off;
+	size_t head;
+	size_t size;
+	struct list_head logs;
 };
 
 static LIST_HEAD(log_list);
 
-
 /**
  * struct logger_reader - a logging device open for reading
  * @log:	The associated log
@@ -76,11 +75,11 @@ static LIST_HEAD(log_list);
  * reference counting. The structure is protected by log->mutex.
  */
 struct logger_reader {
-	struct logger_log	*log;
-	struct list_head	list;
-	size_t			r_off;
-	bool			r_all;
-	int			r_ver;
+	struct logger_log *log;
+	struct list_head list;
+	size_t r_off;
+	bool r_all;
+	int r_ver;
 };
 
 /* logger_offset - returns index 'n' into the log via (optimized) modulus */
@@ -170,17 +169,17 @@ static ssize_t copy_header_to_user(int ver, struct logger_entry *entry,
 	struct user_logger_entry_compat v1;
 
 	if (ver < 2) {
-		v1.len      = entry->len;
-		v1.__pad    = 0;
-		v1.pid      = entry->pid;
-		v1.tid      = entry->tid;
-		v1.sec      = entry->sec;
-		v1.nsec     = entry->nsec;
-		hdr         = &v1;
-		hdr_len     = sizeof(struct user_logger_entry_compat);
+		v1.len = entry->len;
+		v1.__pad = 0;
+		v1.pid = entry->pid;
+		v1.tid = entry->tid;
+		v1.sec = entry->sec;
+		v1.nsec = entry->nsec;
+		hdr = &v1;
+		hdr_len = sizeof(struct user_logger_entry_compat);
 	} else {
-		hdr         = entry;
-		hdr_len     = sizeof(struct logger_entry);
+		hdr = entry;
+		hdr_len = sizeof(struct logger_entry);
 	}
 
 	return copy_to_user(buf, hdr, hdr_len);
-- 
2.1.1

Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

[Greg KH]

On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote:
> This patch removes tabs used to align variable names in declaration and assignation.
> It replaces them with exactly one space.

Why?  This seems like a totally unneeded change, sorry.

greg k-h

Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

[Tristan Lelong]

On Thu, Oct 30, 2014 at 12:08:12AM +0800, Greg KH wrote:
> On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote:
> > This patch removes tabs used to align variable names in declaration and assignation.
> > It replaces them with exactly one space.
> 
> Why?  This seems like a totally unneeded change, sorry.

I thought that was a coding style issue, because of the "c-lineup-arglist-tabs-only" emacs function described in CodingStyle.
I guess I should have read the emacs documentation before assuming that both were linked.

I am sorry for the mistake.