From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: from bus specific dma api to dma api
Date: Thu, 30 Oct 2014 11:07:56 +0530 [thread overview]
Message-ID: <20141030053756.GA3519@sudip-PC> (raw)
In-Reply-To: <20141029084725.GB18675@kroah.com>
On Wed, Oct 29, 2014 at 04:47:25PM +0800, Greg Kroah-Hartman wrote:
> On Wed, Oct 22, 2014 at 02:24:46PM +0530, Sudip Mukherjee wrote:
> > we should be using DMA API rather than using bus specific DMA API.
>
> Why?
>
as given in the DMA-API-HOWTO.txt :
the DMA API works with any bus independent of the underlying
microprocessor architecture.
> > converted the occurrence of pci_map_*() to dma_map_*(),
> > and at the same time used the dma_mapping_error().
>
> Trailing whitespace :(
>
oops .. really sorry . when i checked with checkpatch it didnot show any error.
and I did not know that trailing whitespaces should not be there in the
commit message also.
> What have you used to test this change?
it has just been build tested , not tested on hardware.
thanks
sudip
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2014-10-30 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 8:54 [PATCH] staging: rtl8192e: from bus specific dma api to dma api Sudip Mukherjee
2014-10-29 8:47 ` Greg Kroah-Hartman
2014-10-30 5:37 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030053756.GA3519@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox