From: Josh Triplett <josh@joshtriplett.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Aristeu Rozanski <aris@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP
Date: Thu, 30 Oct 2014 06:32:42 -0700 [thread overview]
Message-ID: <20141030133242.GA32205@thin> (raw)
In-Reply-To: <1414659635.1823.3.camel@jlt4.sipsolutions.net>
On Thu, Oct 30, 2014 at 10:00:35AM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The ENABLE_DEV_COREDUMP option is misleading as it implies that
> it gets the framework enabled, this isn't true it just allows it
> to get enabled if a driver needs it.
>
> Rename it to ALLOW_DEV_COREDUMP to better capture its semantics.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Seems reasonable. The original "DISABLE" was really "FORCE_DISABLE"
(even if used), and the inverse of "FORCE_DISABLE" is not "ENABLE", it's
"ALLOW" (if used).
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/base/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 99d30729d11e..e9f96afe920d 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -171,8 +171,8 @@ config WANT_DEV_COREDUMP
> Drivers should "select" this option if they desire to use the
> device coredump mechanism.
>
> -config ENABLE_DEV_COREDUMP
> - bool "Enable device coredump" if EXPERT
> +config ALLOW_DEV_COREDUMP
> + bool "Allow device coredump" if EXPERT
> default y
> help
> This option controls if the device coredump mechanism is available or
> @@ -187,7 +187,7 @@ config ENABLE_DEV_COREDUMP
> config DEV_COREDUMP
> bool
> default y if WANT_DEV_COREDUMP
> - depends on ENABLE_DEV_COREDUMP
> + depends on ALLOW_DEV_COREDUMP
>
> config DEBUG_DRIVER
> bool "Driver Core verbose debug messages"
> --
> 2.1.0
>
>
prev parent reply other threads:[~2014-10-30 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 13:36 [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Aristeu Rozanski
2014-10-16 13:44 ` Josh Triplett
2014-10-16 15:49 ` Aristeu Rozanski
2014-10-20 9:42 ` Johannes Berg
2014-10-20 11:55 ` Josh Triplett
2014-10-20 22:18 ` Greg Kroah-Hartman
2014-10-20 23:45 ` josh
2014-10-30 8:01 ` Johannes Berg
2014-10-30 9:00 ` [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP Johannes Berg
2014-10-30 12:55 ` Aristeu Rozanski
2014-10-30 13:32 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030133242.GA32205@thin \
--to=josh@joshtriplett.org \
--cc=aris@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox