From: Johan Hovold <johan@kernel.org>
To: Jim Paris <jim@jtan.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
linux-kernel@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>
Subject: Re: [PATCH v4] cdc-acm: ensure that termios get set when the port is activated
Date: Thu, 30 Oct 2014 15:48:58 +0100 [thread overview]
Message-ID: <20141030144858.GG13062@localhost> (raw)
In-Reply-To: <20141030144538.GA23737@psychosis.jim.sh>
On Thu, Oct 30, 2014 at 10:45:38AM -0400, Jim Paris wrote:
> The driver wasn't properly configuring the hardware for the current
> termios settings under all conditions. Ensure that termios are
> written to the device when the port is activated.
>
> Signed-off-by: Jim Paris <jim@jtan.com>
> ---
>
> Moved prototype.
You seem to have posted the old version again.
> ---
> drivers/usb/class/cdc-acm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index e934e19f49f5..d2cd1b6d02a7 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -58,6 +58,9 @@ static struct usb_driver acm_driver;
> static struct tty_driver *acm_tty_driver;
> static struct acm *acm_table[ACM_TTY_MINORS];
>
> +static void acm_tty_set_termios(struct tty_struct *tty,
> + struct ktermios *termios_old);
> +
> static DEFINE_MUTEX(acm_table_lock);
Johan
next prev parent reply other threads:[~2014-10-30 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 23:26 [PATCH] cdc-acm: ensure that termios get set when the port is opened Jim Paris
2014-10-29 1:05 ` Peter Hurley
2014-10-29 13:43 ` [PATCH v2] cdc-acm: ensure that termios get set when the port is activated Jim Paris
2014-10-29 15:07 ` Johan Hovold
2014-10-29 15:30 ` [PATCH] USB: cdc-acm: only raise DTR on transitions from B0 Johan Hovold
2014-10-29 15:56 ` Greg Kroah-Hartman
2014-10-29 15:58 ` Johan Hovold
2014-10-30 0:53 ` [PATCH v3] cdc-acm: ensure that termios get set when the port is activated Jim Paris
2014-10-30 7:51 ` Johan Hovold
2014-10-30 14:45 ` [PATCH v4] " Jim Paris
2014-10-30 14:48 ` Johan Hovold [this message]
2014-10-30 15:04 ` [PATCH v4-real] " Jim Paris
2014-10-31 11:45 ` Johan Hovold
2014-10-31 16:04 ` Oliver Neukum
2014-10-30 6:48 ` [PATCH] USB: cdc-acm: only raise DTR on transitions from B0 Oliver Neukum
2014-11-05 17:41 ` [PATCH Resend] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030144858.GG13062@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jim@jtan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).