From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760729AbaJ3PR6 (ORCPT ); Thu, 30 Oct 2014 11:17:58 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51735 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760225AbaJ3PR4 (ORCPT ); Thu, 30 Oct 2014 11:17:56 -0400 Date: Thu, 30 Oct 2014 16:17:19 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Boris Brezillon , Wim Van Sebroeck , Nicolas Ferre , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH] watchdog: at91rm9200: allow building when using device tree Message-ID: <20141030151719.GG17398@piout.net> References: <1414678534-2677-1-git-send-email-alexandre.belloni@free-electrons.com> <20141030153624.6643c1b4@bbrezillon> <2000678.14fQbcst9s@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2000678.14fQbcst9s@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/10/2014 at 15:43:43 +0100, Arnd Bergmann wrote : > On Thursday 30 October 2014 15:36:24 Boris Brezillon wrote: > > On Thu, 30 Oct 2014 15:15:34 +0100 > > Alexandre Belloni wrote: > > > > > When building with device tree, ARCH_AT91RM9200 may not be selected. Allow > > > building that driver by also depending on ARCH_AT91. > > > > > > Signed-off-by: Alexandre Belloni > > > > Acked-by: Boris Brezillon > > > > Doesn't this reintroduce the bug fixed by commit 09549cd0172 ("watchdog: > Revert the AT91RM9200_WATCHDOG dependency")? > > At least in 3.18-rc2, the driver still uses at91_st_write/at91_st_read. > Hum, right, then we have no better way to express that than depends on SOC_AT91RM9200, would that be acceptable ? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com