From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jeff Epler <jepler@unpythonic.net>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: fix name of 'enable' sysfs file
Date: Thu, 30 Oct 2014 09:56:48 -0700 [thread overview]
Message-ID: <20141030165648.GA7402@kroah.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1410301749560.11562@twin.jikos.cz>
On Thu, Oct 30, 2014 at 05:50:41PM +0100, Jiri Kosina wrote:
> On Thu, 30 Oct 2014, Greg Kroah-Hartman wrote:
>
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Back in commit 5136b2da770d ("PCI: convert bus code to use dev_groups"),
> > I misstyped the 'enable' sysfs file as 'enabled', which broke the
> > userspace api. This patch fixes that issue by renaming the file back.
>
> But this is in turn 3.13 -> 3.18 userspace interface breakage ... I don't
> think there is other graceful way out of this than creating a symlink so
> that both variants work, right?
Given that no one noticed that this was broken until now, I really doubt
that anyone wrote code for the new file name. I recommend just fixing
it back, and getting it into all stable kernel trees and moving on.
A symlink for such a foolish mistake seems like a bigger mistake :)
thanks,
greg k-h
next prev parent reply other threads:[~2014-10-30 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 16:30 [PATCH] PCI: fix name of 'enable' sysfs file Greg Kroah-Hartman
2014-10-30 16:50 ` Jiri Kosina
2014-10-30 16:56 ` Greg Kroah-Hartman [this message]
2014-10-30 17:36 ` Bjorn Helgaas
2014-10-30 21:23 ` Jeff Epler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030165648.GA7402@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=jepler@unpythonic.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox