Re: [PATCH] PM / Hibernate: Migrate to ktime_t

Rafael J. Wysocki
2014-11-08T01:26:42Z

On Thursday, October 30, 2014 08:08:17 PM Arnd Bergmann wrote:
> On Thursday 30 October 2014 11:04:53 Tina Ruchandani wrote:
> > This patch migrates swsusp_show_speed and its callers to using ktime_t instead
> > of 'struct timeval' which suffers from the y2038 problem.
> >
> > Changes to swsusp_show_speed:
> > - use ktime_t for start and stop times
> > - pass start and stop times by value
> > Calling functions affected:
> > - load_image
> > - load_image_lzo
> > - save_image
> > - save_image_lzo
> > - hibernate_preallocate_memory
> > Design decisions:
> > - use ktime_t to preserve same granularity of reporting as before
> > - use centisecs logic as before to avoid 'div by zero' issues caused by
> > using seconds and nanoseconds directly
> > - use monotonic time (ktime_get()) since we only care about elapsed time.
> >
> > Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Patch queued up for 3.19-rc1, thanks!

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.