From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161642AbaJaBme (ORCPT ); Thu, 30 Oct 2014 21:42:34 -0400 Received: from mail-bn1on0135.outbound.protection.outlook.com ([157.56.110.135]:45635 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161426AbaJaBmb (ORCPT ); Thu, 30 Oct 2014 21:42:31 -0400 X-WSS-ID: 0NEACQO-07-4BN-02 X-M-MSG: Date: Fri, 31 Oct 2014 09:34:59 +0800 From: Huang Rui To: Felipe Balbi CC: Alan Stern , Bjorn Helgaas , Greg Kroah-Hartman , "Paul Zimmerman" , Heikki Krogerus , Sergei Shtylyov , Jason Chang , Vincent Wan , Tony Li , , , , Subject: Re: [PATCH v4 16/20] usb: dwc3: add disable usb2 suspend phy quirk Message-ID: <20141031013459.GB20367@hr-slim.amd.com> References: <1414663725-2195-1-git-send-email-ray.huang@amd.com> <1414663725-2195-17-git-send-email-ray.huang@amd.com> <20141030163943.GL10130@saruman> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20141030163943.GL10130@saruman> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(189002)(199003)(51704005)(164054003)(24454002)(50986999)(76176999)(54356999)(87936001)(77096002)(46406003)(19580395003)(4396001)(64706001)(86362001)(85852003)(97756001)(92726001)(92566001)(68736004)(47776003)(120916001)(50466002)(84676001)(83506001)(107046002)(76482002)(23726002)(21056001)(80022003)(31966008)(102836001)(19580405001)(106466001)(97736003)(33656002)(20776003)(99396003)(46102003)(110136001)(53416004)(44976005)(105586002)(85306004)(95666004)(101416001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR02MB195;H:atltwp01.amd.com;FPR:;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB195; X-Exchange-Antispam-Report-Test: UriScan:; X-Forefront-PRVS: 03818C953D Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Ray.Huang@amd.com; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 30, 2014 at 11:39:43AM -0500, Felipe Balbi wrote: > On Thu, Oct 30, 2014 at 06:08:41PM +0800, Huang Rui wrote: > > This patch adds disable usb2 suspend phy quirk, and some special platforms > > can configure that if it is needed. > > > > Signed-off-by: Huang Rui > > --- > > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > > drivers/usb/dwc3/core.c | 7 +++++++ > > drivers/usb/dwc3/core.h | 2 ++ > > drivers/usb/dwc3/platform_data.h | 1 + > > 4 files changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > > index 3720fca..feaf2c8 100644 > > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > > @@ -33,6 +33,7 @@ Optional properties: > > - snps,tx_de_emphasis: the value driven to the PHY is controlled by the > > LTSSM during USB3 Compliance mode. > > - snps,dis_u3_susphy_quirk: when set core will disable USB3 suspend phy. > > + - snps,dis_u2_susphy_quirk: when set core will disable USB2 suspend phy. > > > > This is usually a subnode to DWC3 glue to which it is connected. > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index fdc715a..a28ed1c 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -423,6 +423,10 @@ static void dwc3_phy_setup(struct dwc3 *dwc) > > if (dwc->revision > DWC3_REVISION_194A) > > reg |= DWC3_GUSB2PHYCFG_SUSPHY; > > > > + /* FIXME will move FPGA flag when AMD NL taps out */ > > no need to mention AMD NL here. We still want to have is_fpga flag, just > dwc3-pci will be patches once AMD NL tapes out. > OK, will move it. Thanks, Rui