Re: [PATCH v7 1/7] usb: move the OTG state from the USB PHY to the OTG structure

Antoine Tenart
2014-10-31T13:55:42Z

Hi Felipe,

On Fri, Oct 31, 2014 at 08:47:51AM -0500, Felipe Balbi wrote:
> On Fri, Oct 31, 2014 at 08:33:19AM -0500, Felipe Balbi wrote:
> > > > > > > > > Before using the PHY framework instead of the USB PHY one, we need to
> > > > > > > > > move the OTG state into another place, since it won't be available when
> > > > > > > > > USB PHY isn't used. This patch moves the OTG state into the OTG
> > > > > > > > > structure, and makes all the needed modifications in the drivers
> > > > > > > > > using the OTG state.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > > > > > > > > Acked-by: Peter Chen <peter.chen@freescale.com>
> > > > > > > >
> > > > > > > > Acked-by: Felipe Balbi <balbi@ti.com>
> > > > > > >
> > > > > > > Please rebase on my testing/next and I'll take the series. When
> > > > > > > rebasing, then add Peter's Tested-by/Acked-by where they're missing.
> > > > > >
> > > > > > I just re-sent the series, rebased on your testing/next branch.
> > > > >
> > > > > Thanks, I put them on my testing/next and I'm running build tests.
> > > > >
> > > >
> > > > I see them, I will rebase your testing/next tree for coming chipidea dev, thanks.
> > >
> > > I fixed a build breakage caused by $subject which I fixed, updated patch
> > > below: (Aaro, can I get a tested-by by any chance ?)
> >
> > two more build regressions found (did you build test your patches ??)
>
> and yet another one on phy-isp1301-omap.c. Seriously, if I find another
> build regression I'll drop your series from my queue and defer it to
> 3.20. This is ridiculous already.

Sorry for the inconvenience, the series modify quite a lot of files and
testing all of them is quite difficult. If you'd like I can fully test
it and send a new version early next week.

Deferring it to 3.20 will not solve the issue and will raise the same
errors as these build failures. The series has been sent for quite a
long time now, without having any comments on the latests revisions and
was therefore delayed. Each time it is delayed, it makes it more
difficult to ensure everything is working fine because of all the
modifications done in this subsystem... I tried to keep it up with all
the other patches introduced between my revisions, but this is not as
easy as it sounds.

Again, sorry for these failures, I can send to you a new version early
next week so that no other patches comes in between, breaking the
build...

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering